Closed
Bug 653233
Opened 13 years ago
Closed 13 years ago
Graphs no longer work on trunk
Categories
(Webtools Graveyard :: Graph Server, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: bzbarsky, Assigned: rhelmer)
References
Details
Attachments
(1 file, 1 obsolete file)
436 bytes,
patch
|
catlee
:
review+
|
Details | Diff | Splinter Review |
Apparently they rely on the non-standard document.width/document.height and we removed those. See bug 585877.
Reporter | ||
Updated•13 years ago
|
Severity: normal → major
Assignee | ||
Comment 1•13 years ago
|
||
(In reply to comment #0) > Apparently they rely on the non-standard document.width/document.height and we > removed those. See bug 585877. I see what you mean on graphs.mozilla.org There is a new version (2.0) in the works on http://graphs.allizom.org (uses a nightly snapshot of production data), does everything look ok there? Does to me right now on latest Nightly. I think it's worth fixing for 1.0 though.
Assignee: nobody → rhelmer
Status: NEW → ASSIGNED
Reporter | ||
Comment 2•13 years ago
|
||
2.0 works, I'm told.
Assignee | ||
Comment 3•13 years ago
|
||
Replaced document.width with document.defaultView.getComputedStyle(document.body,null).getPropertyValue('width')
Attachment #528730 -
Flags: review?(catlee)
Attachment #528730 -
Flags: feedback?(bzbarsky)
Reporter | ||
Comment 4•13 years ago
|
||
Comment on attachment 528730 [details] [diff] [review] use getComputedStyle instead of document.width This is fine, but you can just do |.width| instead of |.getPropertyValue("width")|.
Attachment #528730 -
Flags: feedback?(bzbarsky) → feedback+
Also "getComputedStyle" instead of "document.defaultView.getComputedStyle"
Assignee | ||
Comment 6•13 years ago
|
||
More succinct version of attachment 528730 [details] [diff] [review]. Tested on both Firefox 4 and latest Nightly. Thanks bz/sicking for additional review. catlee, would you mind pushing this? I still don't seem to be able to push to hg.m.o/graphs, despite bug 635119.
Attachment #528730 -
Attachment is obsolete: true
Attachment #528730 -
Flags: review?(catlee)
Attachment #528802 -
Flags: review?(catlee)
Assignee | ||
Comment 7•13 years ago
|
||
Comment on attachment 528802 [details] [diff] [review] use getComputedStyle instead of document.width v2 Problem with my hg account resolved, push changeset f7f5ddf4ee84
Attachment #528802 -
Flags: review?(catlee)
Assignee | ||
Comment 8•13 years ago
|
||
Stage updated: http://graphs-stage.mozilla.org/graph.html Filed serverops bug 653358 to push to prod.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Comment 9•13 years ago
|
||
Comment on attachment 528802 [details] [diff] [review] use getComputedStyle instead of document.width v2 Looks like you pushed it already: http://hg.mozilla.org/graphs/rev/f7f5ddf4ee84
Attachment #528802 -
Flags: review+
Assignee | ||
Comment 10•13 years ago
|
||
Pushed to prod, WFM - http://graphs.mozilla.org
Status: RESOLVED → VERIFIED
Updated•8 years ago
|
Product: Webtools → Webtools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•