653306 - Fewer than 6 featured add-ons are shown when you have a featured add-on installed

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Discovery Pane, defect)

Description

[krupa raj[:krupa]]

Attachment: screenshot

steps to reproduce:
1. Load disco pane in next(or load http://tinyurl.com/3enpgyo)
2. Notice the featured add-ons module

observed behavior:
Featured add-ons module has fewer than 6 add-ons. Without recommendations, there are 6 add-ons( https://addons-next.allizom.org/en-US/firefox/discovery/pane/4.0/Darwin). See screenshot

Also, see bug 638696

Comment 1

[Justin Scott [:fligtar]]

I approve of this use of fewer.

Comment 2

[Wil Clouser [:clouserw]]

Attachment: screenshot

I loaded the link in comment 0 in a nightly and it looks fine (see attachment)

Comment 3

[Wil Clouser [:clouserw]]

Need help to confirm this.  Did I do something wrong?  I was using linux - maybe that matters?

Comment 4

[krupa raj[:krupa]]

Wil, try this-

steps to reproduce:
1. Load disco pane in next(or load http://tinyurl.com/3enpgyo)
2. Install one of the featured add-ons
3. reload the page (just to be sure, give it 10 minutes)

expected  behavior:
Featured add-ons module has 6 add-ons (the installed add-on is replaced by some other featured add-on.)

actual behavior:
Featured module has only 5 add-ons.

Comment 5

[Wil Clouser [:clouserw]]

I don't think the steps to reproduce would change anything - that list should be built by what is in the URL (the stuff after the hash), so installing or reloading shouldn't change what is listed there.

Cvan wrote the logic, so CCing him.

Comment 6

[Christopher Van Wiemeersch [:cvan]]

I can't reproduce this. As long as you're using a different URL (with a different hash) after you've installed the add-on, then you should be seeing 6 add-ons.

Comment 7

[Pratibha]

could reproduce this, checked on windows xp as follows:
1)Installed "Tab Scope" from Featured add-ons list
Note: this is one among 6 add-ons listed in Featured add-ons section
2)Reload or close and open Tools->Add-ons

Observed Result: Featured add-ons shows 5 add-ons. Installed add-on is not replaced by other add-on and placeholder is empty

Comment 8

[Pratibha]

Attachment: screenshot displays Discover Pane UI showing 5 add-ons after adding one of the Featured add-on

Comment 9

[Wil Clouser [:clouserw]]

Reloading the link in comment 0 or reopening tools->add-ons will be the difference between this working and not.  Which did you do?  Can you reproduce this by closing the tab and reopening tools->add-ons?  What if you restart Firefox?

Comment 10

[Christopher Van Wiemeersch [:cvan]]

https://github.com/jbalogh/zamboni/commit/c69843e