653647 - Add New Version compatibility checker does not catch incorrect GUID

Status: RESOLVED WORKSFORME

(addons.mozilla.org Graveyard :: Developer Pages, defect, P4)

Description

[Ed Hume]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2.16) Gecko/20110319 Firefox/3.6.16
Build Identifier: current Moz Update as of today

Tonight I uploaded new versions of Aeon, Aeon Clouds and Aeon Colors. When I came to Aeon Colors, I accidentally selected the Aeon Clouds online section to which I uploaded my Aeon Color file.

The Add A New Version compatibility checker cleared the Aeon Colors file for Aeon Clouds. Had I not thought "Hey, wait a minute. I better check," Lord knows what would have happened. The compatibility checker dialog window obscures the name of the Add-On entry, so you can't see what section you are in.

The themes have different GUID's as well as different names, different internal names, and different jarfile names.

Reproducible: Always

Steps to Reproduce:
1. Select an Add-on to update a version. Call it Addon-A.
2. Upload an file for a different Add-on. Call it Addon-B.
3. Run the compatibility checker.

Actual Results:  
The compatibility checker found no errors..

Expected Results:  
The compatibility checker should have told me I was attempting to upload an incorrect addon.

The old AMO and earlier sites used to catch this kind of mistake. I know that from personal experience.

Comment 1

[Jorge Villalobos [:jorgev] (he/him)]

There's a step in the upload process where we check the ID and make sure it's the same. I'll let somebody else confirm this, but I think this bug is INVALID.

Comment 2

[Wil Clouser [:clouserw]]

andym to double check

Comment 3

[Jeff Balogh (:jbalogh)]

The check is in zamboni but not in the validator since the validator does not know about the database and the add-on's metadata.

Comment 4

[Andy McKay]

Attachment: different uuid

Comment 5

[Andy McKay]

Works for me. The initial validation check passes as within itself, its all good. Then when you click add version, it does the AMO checks. I get the attached screenshot and I can't upload the addon. The flow could be improved, but this works for me.