Closed Bug 653750 Opened 13 years ago Closed 13 years ago

download manager is not working

Categories

(Toolkit :: Downloads API, defect)

Product:
Toolkit
Component:
Downloads API
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Tracking Flags:
Tracking Status
firefox6 --- fixed
firefox7 --- fixed

People

(Reporter: powerxaxvi50, Assigned: smontagu)

Details

Attachments

(2 files)

Patch
1.12 KB, patch
Details | Diff | Splinter Review
Patch for the underlying issue
1.39 KB, patch
emk
: review+
asa
: approval-mozilla-aurora+
asa
: approval-mozilla-beta+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (Windows NT 5.1; rv:2.0.1) Gecko/20100101 Firefox/4.0.1
Build Identifier: Mozilla/5.0 (Windows NT 5.1; rv:2.0.1) Gecko/20100101 Firefox/4.0.1

Download manager is not working,it downloads files but not shows nothing.
Download manager window is always clear.I tried to delete downloads.sqlite but not helped .
I have got this problem  from 4.0 version FF



Reproducible: Always
Version: unspecified → 4.0 Branch
(In reply to comment #1)
> Can you reproduce the bug in Safe Mode? 
> https://support.mozilla.com/en-US/kb/Safe+Mode
> 
> ...or with a new clean profile?
> https://support.mozilla.com/en-US/kb/Basic%20Troubleshooting#w_8-make-a-new-profile

Again the same,not helped.
Summary: download manager in not working → download manager is not working
any idea?
I have forgotten to say, many people have the same problem with download manager.
Do you have the options in the pref panel to clear all history?   Do you have AV software running as well?  Have you tried to adjust these settings?
(In reply to comment #4)
> Do you have the options in the pref panel to clear all history?   Do you have
> AV software running as well?  Have you tried to adjust these settings?
What options I need to have in "clear all history"?
AV running kaspersky internet security 2011.I tried without AV but download manager again still not works(it is clear,not shows nothing). Maybe this a bug. All my friends on XP have the same  problems with download manager.
And you really created a fresh profile and did not modify it in any way? All XP computers I have tried on work just fine.
(In reply to comment #6)
> And you really created a fresh profile and did not modify it in any way? All XP
> computers I have tried on work just fine.

YES,I have crated new profile.
I know  6 people on XP with download manager problem .
Do you still have a Clear List button and a Search field when the Download Manager window appears clear, or is the whole window blank?

Is the Clear List button still grey and disabled when you have downloaded something, or does it appear as enabled even though you cannot see an entry in the file list?
(In reply to comment #8)
> Do you still have a Clear List button and a Search field when the Download
> Manager window appears clear, or is the whole window blank?
> 
> Is the Clear List button still grey and disabled when you have downloaded
> something, or does it appear as enabled even though you cannot see an entry in
> the file list?
Yes,manager windows appears always clear  and the Clear list button is always grey and disabled.
Download manager feels nothing :D
I had this problem today using the Nightly.  I see w/o hw acceleration (my ATI drivers are too old to use hw acceleration), the download manager only shows my last download, but if I resize the download manager window it shows the rest of the files on the list.  Not sure if this 100% reproduceable, but I noticed this at least once and after resize its ok.
nika, is this 100% reproducible for you?
(In reply to comment #11)
> nika, is this 100% reproducible for you?
Yes and not only for me.
I confirm this bug. and not only me.
p.s. This bug is not in Linux version of Firefox. Only in Windows. xp and 7 too.
(In reply to comment #5)
> (In reply to comment #4)
> > Do you have the options in the pref panel to clear all history?   Do you have
> > AV software running as well?  Have you tried to adjust these settings?
> What options I need to have in "clear all history"?
> AV running kaspersky internet security 2011.I tried without AV but download
> manager again still not works(it is clear,not shows nothing). Maybe this a bug.
> All my friends on XP have the same  problems with download manager.

I missed this.. remember download history in the option->Privacy->Use Custom settings for history.  Can you confirm this is checked?
> I missed this.. remember download history in the option->Privacy->Use Custom
> settings for history.  Can you confirm this is checked?

Yes, "remember download history"  is checked.
downloads window shows download progress only if it's open at the start of downloading and it shows only progress bars during download, no information about file or estimated time before download process ends. If i close that window and reopen it again it appears blank, no information about downloads is stored.
any solution?
what happens when you resize the download manager window?
(In reply to comment #19)
> what happens when you resize the download manager window?
absolutely nothing.
(In reply to comment #20)
> (In reply to comment #19)
> > what happens when you resize the download manager window?
> absolutely nothing.

Open a new tab and type in the address bar about:config - this will open up a window where you have to click OK to continue (you get a warning about dragons or something, just click OK).

Now you will have a long page of values - look for the one that says browser.download.manager.retention and see if yours is set to 0 rather than 1 - if it is, right click and choose Modify and change the value to 1.

That fixed it for me! :)
(In reply to comment #21)
> (In reply to comment #20)
> > (In reply to comment #19)
> > > what happens when you resize the download manager window?
> > absolutely nothing.
> 
> Open a new tab and type in the address bar about:config - this will open up
> a window where you have to click OK to continue (you get a warning about
> dragons or something, just click OK).
> 
> Now you will have a long page of values - look for the one that says
> browser.download.manager.retention and see if yours is set to 0 rather than
> 1 - if it is, right click and choose Modify and change the value to 1.
> 
> That fixed it for me! :)
it was set to 2. I have changed it to 1 but again nothing happened .
Component: General → Download Manager
Product: Firefox → Toolkit
QA Contact: general → download.manager
Version: 4.0 Branch → Trunk
This sounds like a download manager bug, not a graphics bug.
?
What about this bug?
today updated on 5.0 but again the same problem
what the **** guys ? why not fix this **** bug?
we are suffering !
download manager is not working fix this problem please!!!!!
Someone please tell us how to debug this problem and provide necessary information for Mozilla developers.
It's very likely that you all have an add-on which is breaking Firefox's download manager. Even disabled add-ons can flip and never restore prefs that could break Firefox's download manager. If you can reproduce with all of your add-ons disabled, please test in a clean profile and if it works in a clean profile but not with all add-ons disabled, then list your add-ons here. Thanks.
(In reply to comment #29)
> It's very likely that you all have an add-on which is breaking Firefox's
> download manager. Even disabled add-ons can flip and never restore prefs
> that could break Firefox's download manager. If you can reproduce with all
> of your add-ons disabled, please test in a clean profile and if it works in
> a clean profile but not with all add-ons disabled, then list your add-ons
> here. Thanks.

I have already tried with clean profile and add-ons disable mode (look Comment 1 and Comment 2)
anyway 
my add-on list  :
http://img834.imageshack.us/img834/3964/troubleshootinginformat.png
Hi guys, finally I found cause of this problem.
Download manger problem have  only  Georgian users.
Seems like Download manager have problem with Georgian time standards and format
options.(Georgian unicode)
If we change windows/linux  regional options from Georgian in any other,download manager will work !
axel, can you help find the right owner for this?
Status: UNCONFIRMED → NEW
Ever confirmed: true
This doesn't seem to be related to a Georgian version of Firefox, as we're not shipping that for 4.0+.

I'd suggest to start with an empty profile and a clean install, and please provide detailed download links.
No,no I'm not talking about Georgian version of firefox.
Axel,I tried with clean install and new profile and when system locale is set to Georgian download manager is empty (or shows only file name)  and when system locale is not  set to Georgian Download manager works well.
and what download links?
I'm talking about of this
see image below
http://www.picz.ge/img/s4/1107/11/2/2f96d72f8e87.png
and please tell how to help mozilla developers to fix this problem ?
I suspect that this is an interaction between gecko code triggered by the download manager and a Georgian windows.

nika, can you open the error console, clear the messages and then open the download manager? Make sure that javascript.options.showInConsole is set to true?
I can reproduce this by setting "Georgian" in the Regional format dialog from Windows control panel, without a Georgian version of Windows.

There are no error messages in the error console when the download manager is opened. Using DOM Inspector, I can see that the listbox is not getting populated at all.
I bet there is some bad interaction with APIs that `DownloadUtils.jsm` uses and this locale.
Axel, first of all It is not Georgian windows, just Regional format dialog  is set to Georgian.Error console showed no errors when I opened download manager (javascript.options.showInConsole was set to true)
Simon Montagu thanks.
Attached patch Patch — — Splinter Review 
This patch is wallpaper over the underlying issue, which is that Number.toLocaleString() is throwing "An error occured throwing an exception". I'm investigating further.
Assignee: nobody → smontagu
The "underlying issue" which this fixes is as follows:

When "Georgian" is selected in Regional options, 
  appLocale->GetCategory(NS_LITERAL_STRING(NSILOCALE_TIME), localeStr);
in ToUnicode in js/src/xpconnect/src/xpclocale.cpp returns "ka-GE". ka-GE has no associated Windows codepage, so platformCharset->GetDefaultCharsetForLocale fails (even thought it does return a fallback result of "windows-1252" in the charset parameter), and the function bails out.

The patch makes the windows version GetDefaultCharsetForLocale return a success code instead of a failure code when returning a fallback result, which is what the unix version already does.

FTR, the same bug occurs with any locale that doesn't have a windows codepage. Note also that Date.toLocaleString is broken even with the patch, but I would rather make that a separate bug.
Attachment #545179 - Flags: review?(VYV03354)
Attachment #545179 - Flags: review?(VYV03354) → review+
Comment on attachment 545179 [details] [diff] [review]
Patch for the underlying issue

Asking approval for aurora and beta. The patch is minimal risk and without it the download manager is useless for Windows users in many locales.
Attachment #545179 - Flags: approval-mozilla-beta?
Attachment #545179 - Flags: approval-mozilla-aurora?
Attachment #545179 - Flags: approval-mozilla-beta?
Attachment #545179 - Flags: approval-mozilla-beta+
Attachment #545179 - Flags: approval-mozilla-aurora?
Attachment #545179 - Flags: approval-mozilla-aurora+
This bug will fixed  in next update ?
Yes, if nothing goes wrong between now and then the fix will be released in Firefox 6.
Simon Montagu, thanks.
Mozilla/5.0 (Windows NT 6.1; rv:6.0) Gecko/20100101 Firefox/6.0 beta 2
Mozilla/5.0 (Windows NT 6.1; rv:7.0a2) Gecko/20110713 Firefox/7.0a2
Mozilla/5.0 (Windows NT 6.1; rv:8.0a1) Gecko/20110713 Firefox/8.0a1

Verified issue on Win 7 on Nightly 8, Aurora 7 and Beta 6.0b2 builds using the following steps:
1. Set Regional language to Georgian (as per comment 35)
2. Open builds (Nightly, Aurora, Beta)
3. Download several files and check the status of the Download manager.

The downloaded files are always present. Tried to verify it on WinXP also, but there was no Georgian option in the Regional settings.

Setting status to Verified Fixed.
Status: RESOLVED → VERIFIED
George Carstoiu, on winxp mark this checkbox first(you need to have winxp disk)
http://www.picz.ge/img/s1/1107/15/1/193dabc4f1c4.jpg
and then select Georgian
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: