653874 - Unable to access a few files via file viewer

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect, P5)

Description

[krupa raj[:krupa]]

steps to reproduce:
1.  Load https://addons.allizom.org/en-US/firefox/files/browse/116448/

expected behavior:
Contents of the add-on loads

observed behavior:
Contents don't load. Error message 'There was an error accessing file 116448.' is displayed.

Apr 29 16:26:46 pm-gearman-amo02.mozilla.org: [<anon>][None] z.task:ERROR Error (File is not a zip file) extracting /mnt/netapp_amo/addons.mozilla.org-preview/files/302220/mobile_only_add_on234-1.1-fn-mac.xpi :/data/amo_python/www/preview/zamboni/apps/files/helpers.py:84

Comment 1

[Andy McKay]

Downloaded file and ran it locally and it works fine. Why it thinks its not a zip file, i'm not sure yet.

Comment 2

[Wil Clouser [:clouserw]]

Could be corrupt?  I can poke at it if you want.  Let me know how I can help.

Comment 3

[Wil Clouser [:clouserw]]

I tried opening this file on the machine and it worked fine.  I guess next step is to write a minimal test case and see if it's the python lib - `unzip` on disk is fine.

Comment 4

[Andy McKay]

Unzip's via python libs locally and on khan too.

Comment 5

[Andy McKay]

  File "/data/amo_python/www/preview/zamboni/apps/files/helpers.py", line 84, in extract
    extract_xpi(self.src, self.dest, expand=True)

  File "/data/amo_python/www/preview/zamboni/apps/files/utils.py", line 184, in extract_xpi
    dest = extract_zip(src, remove=True)

  File "/data/amo_python/www/preview/zamboni/apps/files/utils.py", line 141, in extract_zip
    zip = zipfile.ZipFile(source)

  File "/data/amo_python/www/preview/zamboni/vendor/lib/python/zipfile.py", line 693, in __init__
    self._GetContents()

  File "/data/amo_python/www/preview/zamboni/vendor/lib/python/zipfile.py", line 713, in _GetContents
    self._RealGetContents()

  File "/data/amo_python/www/preview/zamboni/vendor/lib/python/zipfile.py", line 725, in _RealGetContents
    raise BadZipfile, "File is not 

It's using the zipfile.py added in vendor, which is probably a good thing.

Comment 6

[Andy McKay]

https://github.com/jbalogh/zamboni/commit/b0168f5c8f31867d0795f850e9d674fed3e0f010

Comment 7

[krupa raj[:krupa]]

verified fixed @ https://addons.allizom.org/en-US/firefox/files/browse/116448/#file-viewer

If there is trouble accessing other files, that will be tracked as new bugs.