Closed
Bug 654372
Opened 13 years ago
Closed 13 years ago
nsWebBrowserPersist init list out of order - "warning: 'nsWebBrowserPersist::mWrapColumn' will be initialized after ... 'PRInt64 nsWebBrowserPersist::mTotalCurrentProgress' ... when initialized here (nsWebBrowserPersist.cpp:234)"
Categories
(Core Graveyard :: Embedding: APIs, defect)
Core Graveyard
Embedding: APIs
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla6
People
(Reporter: dholbert, Assigned: dholbert)
References
()
Details
(Whiteboard: [build_warning])
Attachments
(1 file)
|
1.00 KB,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
nsWebBrowserPersist's init list is out of order since this cset: http://hg.mozilla.org/mozilla-central/rev/b7bfd0871b3f The build warning is: nsWebBrowserPersist.h: In constructor 'nsWebBrowserPersist::nsWebBrowserPersist()': nsWebBrowserPersist.h:244:31: warning: 'nsWebBrowserPersist::mWrapColumn' will be initialized after nsWebBrowserPersist.h:242:31: warning: 'PRInt64 nsWebBrowserPersist::mTotalCurrentProgress' nsWebBrowserPersist.cpp:234:1: warning: when initialized here
|
Assignee | |
Updated•13 years ago
|
|
|
Assignee | |
Comment 1•13 years ago
|
||
|
||
Comment 2•13 years ago
|
||
Comment on attachment 529641 [details] [diff] [review] fix Sorry! In my defense, I *tried* to preserve the correct initialization order! ;-)
Attachment #529641 -
Flags: review?(ehsan) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
No problem. :) Adding checkin-needed keyword, in the hopes that this can ride along with something. (Patch already has author & commit message set correctly, so it can be hg [q]imported)
Keywords: checkin-needed
|
||
Comment 4•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/759cb9d29ef3
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla6
|
||
Updated•5 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•