Closed
Bug 654426
Opened 13 years ago
Closed 13 years ago
Bad display of compose window addressing indicators on Mac following bug 642163
Categories
(Thunderbird :: Message Compose Window, defect)
Tracking
(blocking-thunderbird5.0 needed)
RESOLVED
FIXED
Thunderbird 5.0b1
Tracking | Status | |
---|---|---|
blocking-thunderbird5.0 | --- | needed |
People
(Reporter: standard8, Assigned: andreasn)
References
Details
(Keywords: regression, Whiteboard: [not l10n])
Attachments
(4 files, 1 obsolete file)
9.87 KB,
image/png
|
Details | |
276 bytes,
patch
|
Details | Diff | Splinter Review | |
898 bytes,
patch
|
standard8
:
review+
bwinton
:
ui-review+
|
Details | Diff | Splinter Review |
50.28 KB,
image/png
|
Details |
See the attached screenshot. There's two issues here: 1) For some reason the second and third lines have buttons that seem to be slightly taller. 2) The Newsgroup: text is partially obscured (same with Follow-up to: but that isn't shown here). I'm not sure what is best for the newsgroup text here. Maybe smaller text or a tooltip. Although I'm not convinced a tooltip is really that good for something we should be able to display on the default UI.
Comment 1•13 years ago
|
||
I had only one time access to a Mac for the checks. Actually I have no Mac and I can't investigate this strange problem. About the obscured text: the screenshot shows on the left of Newsgr... more space than the menulist on top (the one after From: ). Maybe it's possible to work with padding/margin. If nothing helps, maybe a new entity in messengercompose.dtd especially for Mac bigger width than for the others can do it.
Reporter | ||
Comment 2•13 years ago
|
||
I'm not sure I'd want to go for a bigger width - it already feels like there's a whole load of empty space outside those areas.
Assignee | ||
Updated•13 years ago
|
Assignee: nobody → nisses.mail
Comment 3•13 years ago
|
||
Standard8 please can you try this patch? I had today the same problem under WinXP by changing aw-menulist to a more native menulist. Important: this patch don't solve the different height.
Richard, I'm going to reopen 654916 as I can reproduce this on other platforms as well, thus it's independent from the Mac-specific menu-width issue here.
Comment 6•13 years ago
|
||
Attachment 530862 [details] in Bug 654916 shows the result with both patches applied. The unequal height looks solved, but the truncation not. The menulists are also to high aligned. Attachment 530865 [details] shows also some problems with the focus ring. :andreasn, is it okay to address the truncation and the focus ring problems in this Bug, because this is Mac only? I think, the focus ring issue is correlated to the aligning.
Reporter | ||
Updated•13 years ago
|
Whiteboard: [not l10n]
Assignee | ||
Comment 7•13 years ago
|
||
Richard: Yeah, I think that makes sense to solve that in this bug
Assignee | ||
Comment 8•13 years ago
|
||
.aw-menulist > .menulist-label { font: icon; -moz-margin-end: 3px; font-size: 10px; } Seems like the above does the trick (for newsgroup at least, not for Followup-to yet). I think my qseries is broken, but I'll try and make a patch.
Assignee | ||
Comment 9•13 years ago
|
||
Comment 10•13 years ago
|
||
Andreas: The dropmarker is now on the right side. Before the composer patches it was on the left. For winXP I used this: /* set the dropmarker at the beginning of the aw-menulist */ .aw-menulist:-moz-locale-dir(ltr), .aw-menulist > .menulist-label-box:-moz-locale-dir(rtl) { direction: rtl; } .aw-menulist:-moz-locale-dir(rtl), .aw-menulist > .menulist-label-box:-moz-locale-dir(ltr) { direction: ltr; } Maybe this works also for OSX
Assignee | ||
Comment 11•13 years ago
|
||
* Sets font size to 10px (same as the other widgets) * Adds Richards padding from attachment 530127 [details] [diff] [review] * Adds the rtl thing, so all labels become right aligned.
Attachment #531291 -
Attachment is obsolete: true
Assignee | ||
Comment 12•13 years ago
|
||
Assignee | ||
Updated•13 years ago
|
Attachment #531314 -
Flags: ui-review?(bwinton)
Attachment #531314 -
Flags: review?(mbanner)
Comment 13•13 years ago
|
||
Comment on attachment 531314 [details] [diff] [review] This should do the trick That looks very nice to me! Thanks, Blake.
Attachment #531314 -
Flags: ui-review?(bwinton) → ui-review+
Reporter | ||
Updated•13 years ago
|
Attachment #531314 -
Flags: review?(mbanner) → review+
Reporter | ||
Comment 14•13 years ago
|
||
Checked in: http://hg.mozilla.org/comm-central/rev/22fe617c4cbd
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.3a4
You need to log in
before you can comment on or make changes to this bug.
Description
•