654718 - Remove WinCE code from xpfe/*

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Ed Morley [:emorley]]

WinCE & Windows Mobile code is being slowly removed by bug 614720 - since it's broken, no longer supported, and only serves to complicate code maintenance. 

This bug is for the xpfe/* parts of the removal:
http://mxr.mozilla.org/mozilla-central/search?string=wince&find=/xpfe/

Comment 1

[Ed Morley [:emorley]]

Attachment: Remove WinCE code from xpfe/*

Comment 2

[Ed Morley [:emorley]]

Comment on attachment 530062 [details] [diff] [review]
Remove WinCE code from xpfe/*

Passed try: http://dev.philringnalda.com/tbpl/?tree=Try&rev=ed18eff9dd9a

Thanks!

Comment 3

[[e-mail]]

Comment on attachment 530062 [details] [diff] [review]
Remove WinCE code from xpfe/*

This block is all obsolete with libxul anyway isn't it? IIRC it only existed because MSVC wouldn't inline nsIntRect so shared builds wouldn't link.

Comment 4

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Yeah, this is all obsolete anyways.  Lets just let the "cleanup libxul stuff" bug get this.

Comment 5

[Ed Morley [:emorley]]

Do you mean bug 648911?

If so, it doesn't touch this file. Should it?

Comment 6

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Maybe.  I'd r+ a patch that just removes the whole ifeq block.

Comment 7

[Ed Morley [:emorley]]

What does/did gkgfx do?

MXR doesn't return much for it and the gkgfx seems to no longer exist?

Comment 8

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

gkgfx was the shared library that gfx/ ended up in.

Comment 9

[Ed Morley [:emorley]]

Attachment: Remove WinCE code from xpfe

Removes the whole ifeq block, per comment 6 suggestion. Isn't removed in the current bug 648911 patch, so doing here instead.

Couldn't tell from comment 6 if the r+ was implicit or whether I needed to re-request, so though I should r? just in case.

Thanks!

Comment 10

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 531660 [details] [diff] [review]
Remove WinCE code from xpfe

It was implicit, but I'll put the stamps here anyways.

Comment 11

[Ed Morley [:emorley]]

Thanks :-)

Comment 12

[Daniel Holbert [:dholbert]]

http://hg.mozilla.org/projects/cedar/rev/13ad023ee970

Comment 13

[Mounir Lamouri (:mounir)]

Pushed:
http://hg.mozilla.org/mozilla-central/rev/13ad023ee970