Closed
Bug 654797
Opened 13 years ago
Closed 13 years ago
Clarify comment about MacOS in documentation for nsIURI::Clone
Categories
(Core :: Networking, defect)
Core
Networking
Tracking
()
RESOLVED
FIXED
People
(Reporter: dholbert, Assigned: dholbert)
References
()
Details
Attachments
(1 file)
1.18 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
<dholbert> Is this actually true? --> "under MacOS, the spec of a file URL does not necessarily uniquely identify a file since two volumes could share the same name." (from http://mxr.mozilla.org/mozilla-central/source/netwerk/base/public/nsIURI.idl?mark=198-200#196 ) <dholbert> (and if so, how do we know which file to load, given a file URI?) <bz> dholbert: as of OSX, I believe this is no longer the case <bholley> bz: ok, thanks <bz> dholbert: but under Classic, it was Assuming bz is correct on this no longer being an issue (CC'ing some mac folks to verify), we should probably clarify the comment in nsIURI.idl to indicate that this applies to *classic* Mac OS. Also, I'm guessing(?) that this wants s/MacOS/Mac OS/ -- at least on Wikipedia*, it's always spelled with a space. * http://en.wikipedia.org/wiki/Macos
Comment 1•13 years ago
|
||
> Assuming bz is correct on this no longer being an issue (CC'ing some > mac folks to verify), we should probably clarify the comment in > nsIURI.idl to indicate that this applies to *classic* Mac OS. I think bz is almost certainly correct ... but I don't know for sure, and don't know how to check. I find that it landed as part of the patch for bug 124042: http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/netwerk/base/public&command=DIFF_FRAMESET&file=nsIURI.idl&rev1=1.24&rev2=1.25&root=/cvsroot Also, it was included with the initial template that Darin Fisher started from when writing his patch (from bug 124042 comment #0): https://bugzilla.mozilla.org/attachment.cgi?id=70883 So this comment is very old (it might predate Darin's patch, which is itself from 2002-03-05, and therefore predates the release of OS X 10.2). Mac OS was still very much alive when it was written, and OS X was quite new -- which could explain why the comment didn't mention Mac OS specifically. In any case, I can't imagine any BSD-compatible file system would let you create two identical filespecs.
Comment 2•13 years ago
|
||
> Also, I'm guessing(?) that this wants s/MacOS/Mac OS/ -- at least on > Wikipedia*, it's always spelled with a space. > > * http://en.wikipedia.org/wiki/Macos Yes, I think "Mac OS" is the correct spelling. But it's probably best just to drop the comment altogether -- to prevent it causing more confusion when someone stumbles across it again 10 years from now :-)
Comment 3•13 years ago
|
||
Oh and by the way, "Mac OS" just is "classic Mac OS". "Mac OS X" != "Mac OS", just like JavaScript != Java :-)
Comment 4•13 years ago
|
||
> Oh and by the way, "Mac OS" just is "classic Mac OS". > > "Mac OS X" != "Mac OS", just like JavaScript != Java :-) I suspect the Wikipedia article is wrong to consider "Mac OS X" a subset of "Mac OS" -- at least I've never used the term "Mac OS" that way.
Assignee | ||
Comment 5•13 years ago
|
||
(In reply to comment #2) > But it's probably best just to drop the comment altogether Sounds good to me. (In reply to comment #3) > Oh and by the way, "Mac OS" just is "classic Mac OS". (I suspected that might be the case... still, I think most non-Mac-developer readers today would interpret "Mac OS" to refer to (or at least include) OS X, and would be confused as I was.)
Comment 6•13 years ago
|
||
> still, I think most non-Mac-developer readers today would interpret
> "Mac OS" to refer to (or at least include) OS X, and would be
> confused as I was
You're probably right -- especially considering that even the
Wikipedia article does this.
All the more reason to drop the comment.
Assignee | ||
Comment 7•13 years ago
|
||
Comment 8•13 years ago
|
||
Comment on attachment 533903 [details] [diff] [review] fix: delete tangential/obsolete part of documentation r=me
Attachment #533903 -
Flags: review?(bzbarsky) → review+
Assignee | ||
Comment 9•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/f6fb5d419d79
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•