Closed
Bug 654941
Opened 13 years ago
Closed 13 years ago
First tab in group has black thumbnail after "Undo close group" is used
Categories
(Firefox Graveyard :: Panorama, defect)
Firefox Graveyard
Panorama
Tracking
(firefox6-)
VERIFIED
FIXED
Firefox 6
| Tracking | Status | |
|---|---|---|
| firefox6 | - | --- |
People
(Reporter: george.carstoiu, Assigned: ttaubert)
References
Details
Attachments
(2 files, 1 obsolete file)
|
512.54 KB,
image/png
|
Details | |
|
4.48 KB,
patch
|
Details | Diff | Splinter Review |
Screenshot 1
Mozilla/5.0 (Windows NT 6.1; rv:6.0a1) Gecko/20110504 Firefox/6.0a1 After pressing the Undo close tab option, the first thumbnail in the group becomes black - see Screenshot 1. Reproducible: always Steps to reproduce: 1. Open a few tabs 2. Go into Panorama 3. Close the group that contains all the tabs 4. Press Undo close tab Actual results: - the first thumbnail in the group is black Expected results: - all tabs are displayed normally This issue may be related to bug 624692.
|
Reporter | |
Updated•13 years ago
|
tracking-firefox6:
--- → ?
Target Milestone: --- → Firefox 6
|
Assignee | |
Updated•13 years ago
|
|
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #530616 -
Flags: feedback?(raymond)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 530616 [details] [diff] [review] patch v1 Tried the patch. It works!
Attachment #530616 -
Flags: feedback?(raymond) → feedback+
|
||
Comment 3•13 years ago
|
||
tracking-firefox flags aren't for suggesting something is important. If you think it's important, work with the leads of that module to get it prioritized.
|
|
Assignee | |
Comment 4•13 years ago
|
||
Comment on attachment 530616 [details] [diff] [review] patch v1 Passed try: http://tbpl.mozilla.org/?tree=Try&pusher=tim.taubert@gmx.de&rev=0b0c5795db4f
|
|
Assignee | |
Comment 5•13 years ago
|
||
Comment on attachment 530616 [details] [diff] [review] patch v1 I hope you are willing to take the review for this, Ehsan :) The main fix here is to call UI.setActive() after all tabItems are shown again. So they're not arranged when hidden. The second test case covers bug 624692 that is fixed by this patch, too.
Attachment #530616 -
Flags: review?(ehsan)
|
||
Updated•13 years ago
|
Attachment #530616 -
Flags: review?(ehsan) → review+
|
|
Assignee | |
Comment 6•13 years ago
|
||
Attachment #530616 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•13 years ago
|
Keywords: checkin-needed
|
||
Comment 7•13 years ago
|
||
http://hg.mozilla.org/projects/cedar/rev/32fc5f49b989
Keywords: checkin-needed
Whiteboard: fixed-in-cedar
|
||
Comment 8•13 years ago
|
||
Pushed: http://hg.mozilla.org/mozilla-central/rev/32fc5f49b989
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: fixed-in-cedar
|
|
Reporter | |
Comment 9•13 years ago
|
||
Mozilla/5.0 (X11; Linux i686; rv:7.0a1) Gecko/20110620 Firefox/7.0a1 Verified on Ubuntu 11.04 x86, Mac OS X 10.6, WinXP, Win 7 x86 using the steps from Comment 0. Setting status to Verified Fixed.
Status: RESOLVED → VERIFIED
|
||
Updated•8 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•