655486 - Session restore from crash always restores after a system shutdown.

Status: RESOLVED INCOMPLETE

(Firefox :: Session Restore, defect)

Description

[Sean K]

User-Agent:       Mozilla/5.0 (X11; Linux x86_64; rv:2.0.1) Gecko/20100101 Firefox/4.0.1
Build Identifier: Mozilla/5.0 (X11; Linux x86_64; rv:2.0.1) Gecko/20100101 Firefox/4.0.1

Even with browser.sessionstore.resume_from_crash set to false, Firefox will reopen my last set of tabs if it gets killed via the system shutdown command.  After reading on the Internet, it seems you guys changed the old way it worked and now I have to instead disable the ability to restore tabs in order to completely kill this feature.  That's crazy -- I shouldn't have to turn off the ability to undo tab closures just so that certain inappropriate websites don't repopulate in my browser every morning.  This hasn't embarrassed me in front of others yet... but it's sure to happen!

Reproducible: Always

Steps to Reproduce:
1.  Open URLs in browser tabs.
2.  Use the system shutdown command in Ubuntu without first closing Firefox cleanly.
3.  Wake up the next morning, open browser.
4.  Tabs repopulate with last night's embarrassing browsing experience.

Actual Results:  
Tabs reopened with previous browsing experience though I don't ever want the store restore to occur.

Expected Results:  
The browser should open on my usual homepage or at least give me the choice to restore my previous session instead of just doing it.

Comment 1

[Thomas Ahlblom]

So the request is to add extra code to Firefox to make it crash instead of shutdown gracefully when it receives a SIGTERM?  I doubt this will get a high priority among the developers.

Doesn't the Private Browsing functionality work for you?
http://support.mozilla.com/en-US/kb/Private+Browsing

Comment 2

[Sean K]

I guess I didn't make myself clear.  It seems to me that it isn't shutting down gracefully when I received a SIGTERM.  It considers it a crash every time and causes all of my tabs to reopen the next time the computer starts.  Additionally I have system restore turned off and yet it still redisplays the tabs.  This is very annoying behavior.  It's a bad user experience to have to shut off undo tab close in order to just not have last night's pron restored every time I start my browser.

Comment 3

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

> After reading on the Internet

I'm curious where you read this and what it actually said. It could be some misinformation.

We shouldn't be restoring from crashes if resume_from_crash = false. Assuming of course that you're crashing. Historically we haven't handled SIGTERM gracefully, but that's not a behavior I would depend on if I were you. If you have things you want to keep private, use Private browsing mode, clear your history, or make sure that session isn't restored.

But let's assume there's a bug here...

If you quit Firefox normally with some tabs open then start up, what happens? (ie, what's the very first preference in the Firefox general settings window?)

Do you have any extensions that might be overriding Firefox's session restore behavior?

Comment 4

[Sean K]

Hi Paul -- not sure where I read it.  Something from Google when I was trying to figure it out.

Resume from crash is definitely false.  And it only happens when I shutdown the system gracefully using "halt" or the shutdown menu item.  If I quit without shutting down, the tabs aren't remembered.

It's not so much a privacy issue -- I'm the only one using the computer -- as it is an annoyance.  I am worried about having someone over sometime and turning on the machine to look up a map or something.  But mostly, it's annoyance.

I have the following extensions installed:

Adblock Plus
Add to Amazon Wishlist Button
Block Site
Download Helper
Global Menu Bar Integration
Invisible Hand
LastPass
Switch to Tab No More
Camelizer
Toolbar Buttons
Ubuntu Firefox Modifications
User Agent Switcher

I also have Firebug and HTTP Headers installed but they're disabled for performance enhancements.

I'll try turning off all the extensions and see if that makes a difference.  I'll update the bug report if it does.

Thanks!

Sean

Comment 5

[Thomas Ahlblom]

Sean, any update on this?