655495 - timeout in widget/src/cocoa/crashtests/373122-1.html

Status: RESOLVED WORKSFORME

(Core :: Widget: Cocoa, defect)

Description

[Jonathan Kew [:jfkthame]]

Crashtest timeout seen on mozilla-central, on a push that doesn't seem related in any way:

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1304782865.1304783359.8832.gz

s: talos-r3-snow-009
REFTEST TEST-UNEXPECTED-FAIL | file:///Users/cltbld/talos-slave/test/build/reftest/tests/widget/src/cocoa/crashtests/373122-1.html | load failed: timed out waiting for reftest-wait to be removed

Comment 1

[Jesse Ruderman]

Here's the crashtest in question:

http://hg.mozilla.org/mozilla-central/annotate/dac74f0a1882/widget/src/cocoa/crashtests/373122-1.html
http://hg.mozilla.org/mozilla-central/annotate/dac74f0a1882/widget/src/cocoa/crashtests/373122-1-inner.html

Comment 2

[Jesse Ruderman]

Attachment: relevant portion of the tinderbox log

Comment 3

[Jesse Ruderman]

The test is slightly suspicious.  The test doesn't ensure that the top-level document's onload fires, and it lets the iframe continue to reload itself after the top-level document removes "reftest-wait".

On the other hand, the log makes it look more like a reftest-content.js bug or a timer GC bug. The test only prints "reloading" twice, so I don't think the inner frame's continuous reloading is actually starving anything.  A GC fires during the test.  reftest-content.js is in STATE_WAITING_FOR_REFTEST_WAIT_REMOVAL, and then it says "AttrModifiedListener fired", but then there's no indication that MakeProgress ran again.

It would be nice to have timestamps in the "Saved log" lines.

Comment 4

[Jesse Ruderman]

I bet this is a dup of bug 623091.

Comment 5

[Ed Morley [:emorley]]

Mass marking whiteboard:[orange] bugs WFM (to clean up TBPL bug suggestions) that:
* Haven't changed in > 6months
* Whose whiteboard contains none of the strings: {disabled,marked,random,fuzzy,todo,fails,failing,annotated,leave open,time-bomb}
* Passed a (quick) manual inspection of bug summary/whiteboard to ensure they weren't a false positive.

I've also gone through and searched for cases where the whiteboard wasn't labelled correctly after test disabling, by using attachment description & basic comment searches. However if the test for which this bug was about has in fact been disabled/annotated/..., please accept my apologies & reopen/mark the whiteboard appropriately so this doesn't get re-closed in the future (and please ping me via IRC or email so I can try to tweak the saved searches to avoid more edge cases).

Sorry for the spam! Filter on: #FFA500