Closed
Bug 655701
Opened 13 years ago
Closed 13 years ago
Remove test dependencies on the html5.parser.enable pref
Categories
(Core :: DOM: HTML Parser, defect)
Core
DOM: HTML Parser
Tracking
()
RESOLVED
FIXED
mozilla6
People
(Reporter: hsivonen, Assigned: hsivonen)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
21.10 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
In order to get rid of the pref itself, we should get rid of all tests that assume that the pref exists. ted, in reference to needing to remove these also due to universalXPConnect removal, do you already happen to have a patch for this?
Comment 1•13 years ago
|
||
No, it was just on the list of things that needed to be dealt with, I hadn't done anything about it.
Blocks: 462483
Assignee | ||
Comment 3•13 years ago
|
||
Assignee | ||
Comment 4•13 years ago
|
||
Comment on attachment 531042 [details] [diff] [review] Remove html5.parser.enable deps from the tests Looks ok on try.
Attachment #531042 -
Flags: review?(ted.mielczarek)
Comment 5•13 years ago
|
||
Comment on attachment 531042 [details] [diff] [review] Remove html5.parser.enable deps from the tests Review of attachment 531042 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, r=me ::: parser/htmlparser/tests/mochitest/test_compatmode.html @@ +63,4 @@ > function test(mode,i){ > is(mode,doctypes[i],doctypes[i+1]); > if (i == doctypes.length - 2) { > + finishTest(); This could just become SimpleTest.finish() and remove the finishTest function. Doesn't matter all that much though.
Attachment #531042 -
Flags: review?(ted.mielczarek) → review+
Assignee | ||
Comment 6•13 years ago
|
||
(In reply to comment #5) > Looks good, r=me Thanks. > This could just become SimpleTest.finish() and remove the finishTest > function. Doesn't matter all that much though. Landed with this changed. http://hg.mozilla.org/mozilla-central/rev/63fe82a5f142
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla6
You need to log in
before you can comment on or make changes to this bug.
Description
•