655731 - If panned prior to discoverability demo start, a grey area is visible behind the visible sidebar

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aaron Train [:aaronmt]]

Attachment: Screenshot

Device: Nexus One

Mozilla/5.0 (Android; Linux armv7l; rv:6.0a1) Gecko/20110509; Firefox/6.0a1 Fennec/6.0a1

If a user pans to expose either left or right sidebars prior to the start of the demo animation on about:firstrun, there will be an exposed grey area to either 
the left or right of the associated sidebar.

See attached screenshot.

IRC: mbrubeck mentions -- 'we need to reset the scroll position before starting the demo'

Comment 1

[Matt Brubeck (:mbrubeck)]

Attachment: patch

This patch just skips the demo if a sidebar is already open when about:firstrun loads.

(As mentioned above, we could also fix this by resetting the scroll position before running the demo.)

Comment 2

[Wesley Johnston (:wesj)]

Comment on attachment 531063 [details] [diff] [review]
patch

I'm fine with this. I think it will be fairly odd that users decide to intentionally visit about:firstrun anyway.

Comment 3

[Matt Brubeck (:mbrubeck)]

http://hg.mozilla.org/mozilla-central/rev/508c54f63824

Comment 4

[Andreea Pod]

Verified fixed on build: Mozilla /5.0 (Android;Linux armv7l;rv:6.0a1) Gecko/20110511 Firefox/6.0a1 Fennec/6.0a1 
Device: LG Optimus 2X (Android 2.2)