655842 - Port |Bug 417483 - Double separator in context menu when selecting empty text & using iframes|

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Ian Neal]

Attachment: Port Firefox patch v1.0

Copied from bug 303898, see testcase - https://bugzilla.mozilla.org/attachment.cgi?id=264095

A double separator appears in the context menu when an image from a *sub-frame*
is highlighted.

Steps to reproduce:
1. Visit testcase.
2. Highlight image, be careful not to select any text, only the image.
3. Activate the context menu over the highlighted image.

Result:
A double separator in the menu.

Comment 1

[[e-mail]]

Comment on attachment 531144 [details] [diff] [review]
Port Firefox patch v1.0

I don't think this is right.

The "quick" fix is to change the test for context-sep-selectall to only show the separator if actual text is selected.

The "better" fix is to reorder the items. I don't think that "This Frame" belongs between "Search ... for ..." and "View Selection Source".

Comment 2

[Ian Neal]

Attachment: Move frame menu instead patch v2.0 [Checked in: Comment 3]

This patch:
* Moves frame menu to just above spell-separator

Comment 3

[Ian Neal]

Comment on attachment 531281 [details] [diff] [review]
Move frame menu instead patch v2.0 [Checked in: Comment 3]

http://hg.mozilla.org/comm-central/rev/5484b8035db5