656460 - Skip dummy frames for function.caller

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Patch

Normally this isn't necessary, but for an upcoming patch, I need to have a dummy frame in the same compartment as the current compartment. The dummy frame isn't really a "caller", so we should skip it.

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

Please pretend that I named the new StackFrame* variable "callerframe" so it doesn't conflict with the JSObject "caller" inside the if statement.

I also made a getCompartment -> compartment renaming while I was there.

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

http://hg.mozilla.org/tracemonkey/rev/2453a6adb500

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

Note that the patch that landed was slightly different than the patch attached here...

Asking for tracking-firefox5 as this is a prerequisite for bug 650273.

Comment 4

[Chris Leary [:cdleary] (not checking bugmail)]

cdleary-bot mozilla-central merge info:
http://hg.mozilla.org/mozilla-central/rev/2453a6adb500

Comment 5

[David Mandelin [:dmandelin]]

Comment on attachment 531764 [details] [diff] [review]
Patch

Please land this patch to mozilla-beta.

Comment 6

[Asa Dotzler [:asa]]

I don't see this in mozilla-beta yet and we're starting to run out of runway. Please land ASAP. Thanks.

Comment 7

[Asa Dotzler [:asa]]

Comment on attachment 531764 [details] [diff] [review]
Patch

pulling back approval and not going to try to fix for Firefox 5.