656844 - Disable drawing of shadows with non-OVER operators

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2011-May/031594.html

I think this is the way the spec should go and I think it's very unlikely to affect Web compatibility.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix v2

Update test_canvas.html to disable tests that assume shadows work with non-over operators.

Comment 3

[Joe Drew (not getting mail)]

Comment on attachment 533234 [details] [diff] [review]
fix v2

Review of attachment 533234 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/canvas/src/nsCanvasRenderingContext2D.cpp
@@ +534,5 @@
>      {
>          ContextState& state = CurrentState();
>  
>          // The spec says we should not draw shadows when the alpha value is 0,
>          // regardless of the operator being used.

You could update this comment if you wanted to

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

http://hg.mozilla.org/projects/cedar/rev/22ec5982eca7

Comment 5

[Mounir Lamouri (:mounir)]

Pushed:
http://hg.mozilla.org/mozilla-central/rev/22ec5982eca7

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Actually I didn't add a testcase specifically for this behavior, and I should have.

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: Testcase

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Bas, you might want to check that Azure behaves correctly with this test/behavior change.

Comment 9

[Joe Drew (not getting mail)]

Comment on attachment 536196 [details] [diff] [review]
Testcase

Review of attachment 536196 [details] [diff] [review]:
-----------------------------------------------------------------

i like this especially for spelling colour correctly

Comment 10

[Robert O'Callahan (:roc) (email my personal email if necessary)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/a565838cfc3a

Comment 11

[Philipp von Weitershausen [:philikon]]

http://hg.mozilla.org/mozilla-central/rev/a565838cfc3a

Comment 12

[Eric Shepherd [:sheppy]]

Documentation updated:

https://developer.mozilla.org/en/Canvas_tutorial/Applying_styles_and_colors#Shadows

And mentioned on Firefox 7 for developers.