656944 - test_hunspell.js is orange w/ unexpected pass, after I fix bug 656829

Status: RESOLVED FIXED

(Core :: Spelling checker, defect)

Description

[Daniel Holbert [:dholbert]]

Per bug 656829, "todo" checks in xpcshell tests aren't handled correctly right now.

I pushed that bug's patch to TryServer to see what latent unexpected results that was hiding, and mercifully there was only 1 failing test, test_hunspell.js.

Tbpl link:
  http://tbpl.mozilla.org/?tree=Try&rev=5adbb650d4ad

Sample log:
http://tinderbox.mozilla.org/showlog.cgi?log=Try/1305280421.1305281480.26946.gz
{
Expect word szerv�z is spelled wrong

TEST-PASS | /home/cltbld/talos-slave/test/build/xpcshell/tests/extensions/spellcheck/hunspell/tests/unit/test_hunspell.js | [do_run_test : 197] false == false
TODO
Expect word szerv�zkocsi is spelled wrong

TEST-UNEXPECTED-PASS | /home/cltbld/talos-slave/test/build/xpcshell/tests/extensions/spellcheck/hunspell/tests/unit/test_hunspell.js | false == false - See following stack:
JS frame :: /home/cltbld/talos-slave/test/build/xpcshell/head.js :: do_throw_todo :: line 462
JS frame :: /home/cltbld/talos-slave/test/build/xpcshell/head.js :: _do_check_eq :: line 551
JS frame :: /home/cltbld/talos-slave/test/build/xpcshell/head.js :: todo_check_eq :: line 567
JS frame :: /home/cltbld/talos-slave/test/build/xpcshell/head.js :: todo_check_false :: line 595
JS frame :: /home/cltbld/talos-slave/test/build/xpcshell/tests/extensions/spellcheck/hunspell/tests/unit/test_hunspell.js :: do_run_test :: line 195
JS frame :: /home/cltbld/talos-slave/test/build/xpcshell/tests/extensions/spellcheck/hunspell/tests/unit/test_hunspell.js :: do_run_test_closure :: line 216
JS frame :: /home/cltbld/talos-slave/test/build/xpcshell/tests/extensions/spellcheck/hunspell/tests/unit/test_hunspell.js :: run_test :: line 219
JS frame :: /home/cltbld/talos-slave/test/build/xpcshell/head.js :: _execute_test :: line 326
JS frame :: -e :: <TOP_LEVEL> :: line 1

TEST-INFO | (xpcshell/head.js) | exiting test
}

Filing this bug on fixing up this test so that it knows what passes and what fails.  (hopefully that's just changing one or more todo's to "do", as long as it makes sense that these checks are passing).

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix

After fixing the unexpected pass in comment 0, there were four more unexpected passes that showed themselves.  This patch undoes the "todo" labeling on all of them and makes the test pass, as a whole.

Comment 2

[Daniel Holbert [:dholbert]]

Just for the record, those four unexpected passes are:
{
getting file by line for file /data/opentaal_keepcase.wrong
using charset UTF-8
[...]
TODO
Expect word Nato-word is spelled wrong

TEST-UNEXPECTED-PASS | /test_hunspell.js | false == false - See following stack:

******************
getting file by line for file /data/2999225.good
using charset iso-8859-1
TODO
Expect word foobar is spelled correctly

TEST-UNEXPECTED-PASS | /test_hunspell.js | true == true - See following stack:

******************
getting file by line for file /data/onlyincompound2.wrong
using charset iso-8859-1
[...]
TODO
Expect word foopseudos is spelled wrong

TEST-UNEXPECTED-PASS | /test_hunspell.js | false == false - See following stack:

******************

getting file by line for file /data/forceucase.wrong
using charset iso-8859-1
TODO
Expect word foobaz is spelled wrong

TEST-UNEXPECTED-PASS | /test_hunspell.js | false == false - See following stack:
}

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 532261 [details] [diff] [review]
fix

r=me assuming it passes try.

We integrated the test suite from hunspell 1.3.1 while we had an older version actually in the tree, which is likely the reason for these fixes.

Comment 4

[Daniel Holbert [:dholbert]]

This bug's test passed on try (though I was unlucky enough to base my try push off of a m-c revision that had a permaorange in a *different* xpcshell test.  that was the only orange thing, though.)

Pushed to cedar:
http://hg.mozilla.org/projects/cedar/rev/617c48514c63

Comment 5

[Jason Duell]

http://hg.mozilla.org/mozilla-central/rev/617c48514c63