Closed
Bug 656992
Opened 13 years ago
Closed 13 years ago
546 lines of build warning spam from "NeckoMessageUtils.h:* warning: unused variable 'rv'"
Categories
(Core :: Networking, defect)
Core
Networking
Tracking
()
RESOLVED
FIXED
People
(Reporter: dholbert, Assigned: dholbert)
References
()
Details
(Whiteboard: [build_warning] )
Attachments
(1 file)
|
2.80 KB,
patch
|
jduell.mcbugs
:
review+
|
Details | Diff | Splinter Review |
When building an opt build, we get 546 lines of this build-warning-spam:
> NeckoMessageUtils.h: In static member function 'static void IPC::ParamTraits<IPC::InputStream>::Write(IPC::Message*, const IPC::ParamTraits<IPC::InputStream>::paramType&)':
> NeckoMessageUtils.h:219:18: warning: unused variable 'rv'
> NeckoMessageUtils.h:230:14: warning: unused variable 'rv'
(Apparently lots of files include that header, directly or indirectly)
|
Assignee | |
Updated•13 years ago
|
OS: Linux → All
Hardware: x86_64 → All
Summary: 550 lines of build warning spam from "NeckoMessageUtils.h:* warning: unused variable 'rv'" → 546 lines of build warning spam from "NeckoMessageUtils.h:* warning: unused variable 'rv'"
|
|
Assignee | |
Updated•13 years ago
|
|
|
Assignee | |
Comment 1•13 years ago
|
||
This fixes these spots using the magical new DebugOnly template.*
I've also fixed one existing instance of...
#ifdef DEBUG
nsresult rv =
#endif
// some expression
// sanity-check rv
...to use DebugOnly, too.
* https://developer.mozilla.org/index.php?title=En/Namespace/Mozilla/DebugOnly%3CT%3EAssignee: nobody → dholbert
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•13 years ago
|
Attachment #532321 -
Flags: review?(jduell.mcbugs)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 532321 [details] [diff] [review] fix: use mozilla::DebugOnly<nsresult> What do you know--every once in a while C++ is actually slick in an almost straightforward way. Thanks for the patch!
Attachment #532321 -
Flags: review?(jduell.mcbugs) → review+
|
|
||
Updated•13 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Comment 3•13 years ago
|
||
Thanks for the speedy review! http://hg.mozilla.org/projects/cedar/rev/cf70935c912b
Keywords: checkin-needed
Whiteboard: [build_warning] → [build_warning] fixed-in-cedar
|
|
||
Comment 4•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/cf70935c912b
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
|
||
Updated•13 years ago
|
Whiteboard: [build_warning] fixed-in-cedar → [build_warning]
You need to log in
before you can comment on or make changes to this bug.
Description
•