Closed Bug 657214 Opened 13 years ago Closed 13 years ago

The Composer status bar doesn't display the correct status.

Categories

(SeaMonkey :: Composer, defect)

Product:
SeaMonkey
Component:
Composer
Type:
defect
Priority:
Not set
Severity:
major

Tracking

(seamonkey2.2 fixed, seamonkey2.3 fixed)

Status:
RESOLVED FIXED
Milestone:
seamonkey2.2
Tracking Flags:
Tracking Status
seamonkey2.2 --- fixed
seamonkey2.3 --- fixed

People

(Reporter: suxindong, Assigned: iannbugzilla)

References

Details

(Keywords: regression)

Attachments

(1 file)

Move to correct commandset [Checked in trunk/aurora/beta: Comment 11]
1.34 KB, patch
neil
: review+
kairo
: approval-comm-aurora+
kairo
: approval-comm-beta+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (Windows NT 5.2; rv:2.0.1) Gecko/20110511 Firefox/4.0.1 SeaMonkey/2.1
Build Identifier: Mozilla/5.0 (Windows NT 5.2; rv:2.0.1) Gecko/20110511 Firefox/4.0.1 SeaMonkey/2.1

1. use composer to open any html file/url. No matter where you click on the page, the status bar always and only shows "<body>".

2. locate the cursor into some structure of the page, like a table. Switch to "source edit" mode then switch back to "Normal" mode, the status bar shows the right html tags of the cursor location. But the content of the status bar won't update when you move the cursor.


Reproducible: Always

Steps to Reproduce:
see the bug details.


Expected Results:  
the status bar should work like before.
Hi 
I have the same behavior.

I have found a part of the Problem:

The command cmd_updateStructToolbar is transfered from commandset composerStyleMenuItems in editorOverlay.xul to editorCommands in editor.xul

When i changed the focus only the command update from all composerStyleMenuItems commands are triggered. 

I don't find the source of this trigger.
cc IanN on the assumption that his refactoring caused this.
Summary: the status bar is malfunction → The Composer status bar doesn't display the correct status.
cmd_updateStructToolbar belongs in composerStyleMenuItems but it got put into composerOnlyMenuItems by mistake...
Blocks: 639716
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: regression
OS: Windows Server 2003 → All
Hardware: x86 → All
Assignee: nobody → iann_bugzilla
Status: NEW → ASSIGNED
Version: unspecified → Trunk
I have determined where the command is triggered.

composerStyleMenuItems has the events="create, style, mode_switch"
composerOnlyMenuItems  has only events="create, mode_switch"

There are two options:
1. like comment 4 
   move cmd_updateStructToolbar back to composerStyleMenuItems

2. use the patch below

diff -r a4ca77b7517a editor/ui/composer/content/editor.xul
--- a/editor/ui/composer/content/editor.xul     Sun Jun 19 00:39:30 2011 -0400
+++ b/editor/ui/composer/content/editor.xul     Sun Jun 19 15:31:00 2011 +0200
@@ -100,7 +100,7 @@
     <commandset id="composerMenuItems"/>
     <commandset id="composerOnlyMenuItems"
                 commandupdater="true"
-                events="create, mode_switch"
+                events="create, style, mode_switch"
                 oncommandupdate="goUpdateComposerMenuItems(this);">
       <!-- file menu -->
       <command id="cmd_exportToText"
Have a look at bug 665265 
I think it is duplicate to this.
Now I understand how your patch works.
My patch in commant 5 is obsolete.
Comment on attachment 540364 [details] [diff] [review]
Move to correct commandset [Checked in trunk/aurora/beta: Comment 11]

[what does hg diff think it's doing?]
Attachment #540364 - Flags: review?(neil) → review+
Comment on attachment 540364 [details] [diff] [review]
Move to correct commandset [Checked in trunk/aurora/beta: Comment 11]

Would be good to get this simple regression fix into both aurora and beta.
Attachment #540364 - Flags: approval-comm-beta?
Attachment #540364 - Flags: approval-comm-aurora?
Attachment #540364 - Flags: approval-comm-beta?
Attachment #540364 - Flags: approval-comm-beta+
Attachment #540364 - Flags: approval-comm-aurora?
Attachment #540364 - Flags: approval-comm-aurora+
Comment on attachment 540364 [details] [diff] [review]
Move to correct commandset [Checked in trunk/aurora/beta: Comment 11]

http://hg.mozilla.org/comm-central/rev/db68cef40376
http://hg.mozilla.org/releases/comm-aurora/rev/1cb7425596bf
http://hg.mozilla.org/releases/comm-beta/rev/a49dd4679f55
Attachment #540364 - Attachment description: Move to correct commandset → Move to correct commandset [Checked in trunk/aurora/beta: Comment 11]
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.2
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: