Closed
Bug 657447
Opened 13 years ago
Closed 13 years ago
Missing include guards in nsTimeRange class
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla6
People
(Reporter: padenot, Assigned: padenot)
Details
Attachments
(1 file, 2 obsolete files)
1.26 KB,
patch
|
mounir
:
review+
|
Details | Diff | Splinter Review |
There is no include guards in this .h file.
Assignee | ||
Updated•13 years ago
|
Assignee: nobody → paul
Assignee | ||
Comment 1•13 years ago
|
||
Attachment #532722 -
Flags: review?(chris)
Comment 2•13 years ago
|
||
Comment on attachment 532722 [details] [diff] [review] Patch v1, adding input guards Review of attachment 532722 [details] [diff] [review]: ----------------------------------------------------------------- ::: content/html/content/src/nsTimeRanges.h @@ +41,5 @@ > #include "nsTArray.h" > > +#if !defined(nsTimeRanges_h__) > +#define nsTimeRanges_h__ > + Please put this before the list of #include and use "ifndef" instead of "!defined".
Attachment #532722 -
Flags: review?(chris) → review-
Assignee | ||
Comment 3•13 years ago
|
||
Attachment #532722 -
Attachment is obsolete: true
Attachment #532750 -
Flags: review?(mounir.lamouri)
Comment 4•13 years ago
|
||
Comment on attachment 532750 [details] [diff] [review] Patch v1, adressing Mounir's concerns Review of attachment 532750 [details] [diff] [review]: ----------------------------------------------------------------- ::: content/html/content/src/nsTimeRanges.h @@ +37,5 @@ > * ***** END LICENSE BLOCK ***** */ > > +#if !defined(nsTimeRanges_h__) > +#define nsTimeRanges_h__ > + Please, don't use !defined but ifndef instead.
Attachment #532750 -
Flags: review?(mounir.lamouri) → review+
Assignee | ||
Comment 5•13 years ago
|
||
I usually use #ifndef, but decided to be consistent with the other file of the module. Anyway, here's the corrected version.
Attachment #532750 -
Attachment is obsolete: true
Assignee | ||
Updated•13 years ago
|
Attachment #532754 -
Flags: review?(mounir.lamouri)
Comment 6•13 years ago
|
||
Comment on attachment 532754 [details] [diff] [review] Patch v3 Review of attachment 532754 [details] [diff] [review]: ----------------------------------------------------------------- Thanks :)
Attachment #532754 -
Flags: review?(mounir.lamouri) → review+
Updated•13 years ago
|
Keywords: checkin-needed
Keywords: checkin-needed
Updated•13 years ago
|
Whiteboard: [fixed in cedar]
Comment 8•13 years ago
|
||
Pushed: http://hg.mozilla.org/mozilla-central/rev/92f83b5cded7
Status: NEW → RESOLVED
Closed: 13 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Whiteboard: [fixed in cedar]
Target Milestone: --- → mozilla6
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•