Closed
Bug 657487
Opened 13 years ago
Closed 13 years ago
Include static keyword in definitions of signal callback functions
Categories
(Core :: Widget: Gtk, defect)
Tracking
()
RESOLVED
FIXED
mozilla6
People
(Reporter: hiro, Assigned: hiro)
Details
Attachments
(1 file)
|
18.27 KB,
patch
|
karlt
:
review+
|
Details | Diff | Splinter Review |
I do not know why those functions are not static but I guess those were copy-and-paste from static method of nsWindow class.
|
Assignee | |
Updated•13 years ago
|
Attachment #532758 -
Flags: review?(karlt)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 532758 [details] [diff] [review] A patch AFAIK all of these methods already have internal linkage due to the static keyword in their declaration, but it makes sense to me to explicitly specify in the definition also.
Attachment #532758 -
Flags: review?(karlt) → review+
|
|
||
Updated•13 years ago
|
Summary: Callback functions of signals shoud be static function → Include static keyword in definitions of signal callback functions
|
|
Assignee | |
Updated•13 years ago
|
Assignee: nobody → hiikezoe
Keywords: checkin-needed
|
||
Comment 2•13 years ago
|
||
Hiroyuki, when adding "checkin-needed" on a bug, could you make sure your patch is properly formatted so the push is easier to do. See these links: https://developer.mozilla.org/en/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3f http://blog.bonardo.net/2010/06/22/so-youre-about-to-use-checkin-needed And thanks for all these patches :)
Status: NEW → ASSIGNED
Keywords: checkin-needed
Whiteboard: [fixed in cedar]
Version: unspecified → Trunk
|
|
||
Comment 3•13 years ago
|
||
Pushed: http://hg.mozilla.org/mozilla-central/rev/72dc5f89f9cd
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Whiteboard: [fixed in cedar]
Target Milestone: --- → mozilla6
You need to log in
before you can comment on or make changes to this bug.
Description
•