Closed
Bug 657528
Opened 13 years ago
Closed 13 years ago
Use a volatile pointer to force a trap.
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla6
People
(Reporter: espindola, Assigned: espindola)
Details
Attachments
(1 file, 1 obsolete file)
|
1.12 KB,
patch
|
Details | Diff | Splinter Review |
Clang issues the warning:
mozalloc_abort.cpp:64:22: warning: indirection of non-volatile null pointer will be deleted, not trap [-Wnull-dereference]
And sure enough, TouchBadMemory is currently broken with clang. That breaks mozalloc_abort which breaks NS_DebugBreak which breaks the crashreport test.
Attachment #532808 -
Flags: review?(ehsan)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 532808 [details] [diff] [review] Use a volatile pointer to force a trap. r=me. Nit: can you please fix the comment indentation? Thanks!
Attachment #532808 -
Flags: review?(ehsan) → review+
|
Assignee | |
Comment 2•13 years ago
|
||
Attachment #532808 -
Attachment is obsolete: true
Attachment #532812 -
Flags: review?(ehsan)
|
|
Assignee | |
Updated•13 years ago
|
Attachment #532812 -
Flags: review?(ehsan) → review?
|
|
Assignee | |
Updated•13 years ago
|
Attachment #532812 -
Flags: review?
|
|
Assignee | |
Updated•13 years ago
|
Keywords: checkin-needed
|
|
||
Comment 3•13 years ago
|
||
http://hg.mozilla.org/projects/cedar/rev/7839f528cda0
Assignee: nobody → respindola
Status: NEW → RESOLVED
Closed: 13 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
|
|
||
Comment 4•13 years ago
|
||
Man, I'm too used to landing stuff on m-c now!
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Whiteboard: fixed-in-cedar
|
||
Comment 5•13 years ago
|
||
Pushed: http://hg.mozilla.org/mozilla-central/rev/7839f528cda0
Status: REOPENED → RESOLVED
Closed: 13 years ago → 13 years ago
OS: Mac OS X → All
Hardware: x86 → All
Resolution: --- → FIXED
Whiteboard: fixed-in-cedar
Target Milestone: --- → mozilla6
Version: unspecified → Trunk
You need to log in
before you can comment on or make changes to this bug.
Description
•