657543 - Should be able to un-bookmark through the awesomebar

Status: REOPENED

(Firefox :: Address Bar, enhancement, P5)

Description

[Justin Lebar (not reading bugmail)]

Use case: I have

  http://tbpl.mozilla.org/?tree=MozillaTry&pusher=[e-mail]

bookmarked.  But this is no longer a valid URL -- it should be tree=Try.  When I visit the invalid URL, I'm redirected to wrongtree.html.

It's therefore hard for me to un-bookmark this page -- I can't visit the page and click the star, since whenever I visit, I get redirected away.

It seems like it would be useful if I could un-bookmark by clicking the star in the awesomebar, or selecting the result and pressing <delete> or right-clicking the result, or something.

Comment 1

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

I suppose this is a redirect permanent? we could probably automatic update bookmarks when the original uri gets such a transition.
But yeah, I've seen this concern in the past, the locationbar allows to remove history, but not bookmarks, adding an hidden shortcut would not be discoverable at all though (as it's not discoverable for history).

Comment 2

[Justin Lebar (not reading bugmail)]

> I suppose this is a redirect permanent? we could probably automatic update 
> bookmarks when the original uri gets such a transition.

I'm not so sure about that.  If I bookmarked

  http://nytimes.com/my-favorite-article.html

and now that redirects to

  http://nytimes.com/article-does-not-exist

do I really want the URL of the bookmark switched to the second one?  Maybe I'd want to keep the first bookmark URL for purposes of remembering what I had.  (Especially since once other awesomebar bugs get fixed, the title of the bookmark would update to match the title of the new page.)

Comment 3

[Justin Lebar (not reading bugmail)]

For more on redirects, see bug 576405.

Comment 4

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

(In reply to comment #2)
> do I really want the URL of the bookmark switched to the second one?  Maybe
> I'd want to keep the first bookmark URL for purposes of remembering what I
> had.

Well, a arrow panel growing from the star (I guess) may ask you if you wish to update the bookmark or not and remember the answer. Maybe annoying?

There is also bug 327024 that is about making the star aware of redirects (so if you're on a page you were redirected to from a bookmarked page, it could somehow manage it as a bookmark, showing some kind of difference (maybe a small whirling arrow on the star to show redirected-from-a-bookmark?)

Comment 5

[Shawn Wilsher :sdwilsh]

(In reply to comment #1)
> I suppose this is a redirect permanent? we could probably automatic update
> bookmarks when the original uri gets such a transition.
> But yeah, I've seen this concern in the past, the locationbar allows to remove
> history, but not bookmarks, adding an hidden shortcut would not be discoverable
> at all though (as it's not discoverable for history).
We don't want to do this automatically.  MITM attacks could then change a bunch of bookmarked urls for the user, and that seems undesirable.  UI for it though seems like a good idea.

Comment 6

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Good point, yes probably fixing bug 327024 is the way to go.

Comment 7

[Cees T.]

I can't unbookmark any URI now, not even the one of this page.

Firefox 14.0.1 on 64-bit Windows 7 Enterprise. Only 2 Adobe Flash Player plugins active, and 8 extensions that i wish i could copy/paste the info of.

Comment 8

[Cees T.]

I still cannot toggle any bookmark in Aurora 23.0a2 (2013-05-18).

Comment 9

[BMO Automation]

Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.