Closed
Bug 657548
Opened 13 years ago
Closed 13 years ago
Remove duplicate and unused CIDs from nsContentCID.h and nsLayoutCID.h
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla6
People
(Reporter: craig.topper, Assigned: craig.topper)
Details
Attachments
(2 files)
12.99 KB,
patch
|
jst
:
review+
|
Details | Diff | Splinter Review |
4.52 KB,
patch
|
jst
:
review+
|
Details | Diff | Splinter Review |
nsContentCID.h and nsLayoutCID.h have several CIDs duplicated. Fortunately, they have identical values. While reviewing I also found several unused CIDs so I'm removing those as well. I don't claim it to be a complete review and there could still be others that are unused.
Assignee | ||
Comment 1•13 years ago
|
||
Assignee | ||
Comment 2•13 years ago
|
||
Comment on attachment 532870 [details] [diff] [review] Remove duplicate and unused CIDs from nsContentCID.h and nsLayoutCID.h This patch also moves the CID for audio element to ContentCID.h since that's where the other elements live. All the duplicates were left in the file appropriate to where the implementation lives.
Attachment #532870 -
Flags: review?(jst)
Assignee | ||
Comment 3•13 years ago
|
||
Assignee | ||
Updated•13 years ago
|
Attachment #532875 -
Flags: review?(jst)
Updated•13 years ago
|
Attachment #532870 -
Flags: review?(jst) → review+
Comment 4•13 years ago
|
||
Comment on attachment 532875 [details] [diff] [review] Part 2: Remove more unused CIDs. r=jst!
Attachment #532875 -
Flags: review?(jst) → review+
Assignee | ||
Updated•13 years ago
|
Keywords: checkin-needed
Comment 5•13 years ago
|
||
http://hg.mozilla.org/projects/cedar/rev/e6c321d64c85 http://hg.mozilla.org/projects/cedar/rev/49eaed73c95d
Comment 6•13 years ago
|
||
Pushed: http://hg.mozilla.org/mozilla-central/rev/e6c321d64c85 http://hg.mozilla.org/mozilla-central/rev/49eaed73c95d
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-cedar]
Target Milestone: --- → mozilla6
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•