657780 - FrameLayerBuilder warning pldhash

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Benjamin Stover (:stechz)]

On Fennec with every mousemove I get the warning:
pldhash: for the table at address %p, the given entrySize of 84 definitely favors chaining over double hashign.

The key for a ThebesLayerItemsEntry is rather large at the size of 84 bytes. This seems like a pretty enormous key. Perhaps the key should be a pointer to this data?

Comment 1

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

This happens on Firefox too.

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

FWIW, the spam here is severe enough that I'd consider backing out the patch that introduced this.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

Comment 4

[Timothy Nikkel (:tnikkel)]

Comment on attachment 533116 [details] [diff] [review]
fix

   /**
    * Save aMatrix as the transform that was in aLayer when we last painted.
    */
-  void SaveLastPaintTransform(ThebesLayer* aLayer, const gfx3DMatrix& aMatrix);
+  void SaveLastPaintOffset(ThebesLayer* aLayer);
   /**
    * Get the transform that was in aLayer when we last painted. It's either
    * the transform saved by SaveLastPaintTransform, or else the transform
    * that's currently in the layer.
    */
-  const gfx3DMatrix& GetLastPaintTransform(ThebesLayer* aLayer);
+  nsIntPoint GetLastPaintOffset(ThebesLayer* aLayer);

The comments need updating here.

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix v2

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

http://hg.mozilla.org/projects/cedar/rev/a519b72356bf

Comment 7

[Mounir Lamouri (:mounir)]

Pushed:
http://hg.mozilla.org/mozilla-central/rev/a519b72356bf