657872 - Remove apps/l10n_site

Status: VERIFIED FIXED

(Webtools Graveyard :: Elmo, defect)

Description

[Staś Małolepszy :stas]

Are we using it for anything still?

Comment 1

[Peter Bengtsson [:peterbe]]

Attachment: Removing apps/l10n_site

No, we do not need this app for anything any more. All tests pass

Made the diff like this:
  `git diff --summary develop > ~/tmp/bug657872.summary.diff`
So it's not really a diff but it'll do I guess

Comment 2

[Staś Małolepszy :stas]

Comment on attachment 533206 [details] [diff] [review]
Removing apps/l10n_site

r=me, bye bye l10n_site.  You served us well.

Comment 3

[Peter Bengtsson [:peterbe]]

Landed https://github.com/mozilla/elmo/commit/efd6e1668341c32a5f04caada32d3dde67fb2207

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

How do we verify this?  Just that https://l10n-stage-sj.mozilla.org/apps/l10n_site is a 404?

Comment 6

[Peter Bengtsson [:peterbe]]

(In reply to comment #5)
> How do we verify this?  Just that
> https://l10n-stage-sj.mozilla.org/apps/l10n_site is a 404?

It wouldn't necessarily become a URL but you can confirm that it's gone from the source here :)
https://github.com/mozilla/elmo/tree/develop/apps

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on https://github.com/mozilla/elmo/commit/efd6e1668341c32a5f04caada32d3dde67fb2207, and in https://github.com/mozilla/elmo/tree/develop/apps (lack of the dir).

Thanks!