658063 - Move votes_container css style to external style.css instead of template

Status: RESOLVED FIXED

(Bugzilla :: Extensions, defect)

Description

[David Lawrence [:dkl]]

Attachment: Patch that moves CSS style from template to style.css (v1)

Patch that moves the CSS style for #votes_container from the template to the style.css file instead.

Comment 1

[Max Kanat-Alexander]

Comment on attachment 533413 [details] [diff] [review]
Patch that moves CSS style from template to style.css (v1)

Awesome, thank you. However, adding <link> tags directly into the headers is actually not the way that things should be done anymore, if you can avoid it. Instead, you want to push the style URL into the style_urls array in the header-start.html.tmpl hook.

If that doesn't work (a) let me know and (b) keep the <link> tag and do FILTER mtime on the href portion.

Comment 2

[Max Kanat-Alexander]

Also, in curiosity--what's happening that you want to have this style.css loaded by every page in Bugzilla?

Comment 3

[David Lawrence [:dkl]]

(In reply to comment #2)
> Also, in curiosity--what's happening that you want to have this style.css
> loaded by every page in Bugzilla?

It shouldn't. I am doing [% IF bug %] in the current patch so it should only load for show_bug.cgi. Is there a way to check for bug/show.html.tmpl in the header-start.html.tmpl hook template instead?

The reasoning for the patch is to fix HTML validation issues pointed out by bug 652413.

dkl

Comment 4

[David Lawrence [:dkl]]

Nevermind. I see now.

[% IF template.name == 'bug/show.html.tmpl' %]

dkl

Comment 5

[Max Kanat-Alexander]

Ah, that wouldn't work though, because the edit form gets loaded by things other than show. You want to hook the special header stuff in bug/.

Comment 6

[David Lawrence [:dkl]]

Attachment: Patch that moves CSS style from template to style.css (v2)

New patch that uses header-start.html.tmpl to add the stylesheet to style_urls list. I tried different methods to use the special header stuff mentioned before and I couldn't seem to get it to work as I thought it would. Although the way this patch is written it does work. 

dkl

Comment 7

[Max Kanat-Alexander]

dkl: Add an "end" hook to bug/show-header.html.tmpl.

Comment 8

[David Lawrence [:dkl]]

Attachment: Patch that moves CSS style from template to style.css (v3)

New patch that relies on 'end' hook in show-header.html.tmpl to add to style_urls the path the Voting stylesheet. Depends on patch in bug 659124. Works good for me. 

dkl

Comment 9

[Max Kanat-Alexander]

Comment on attachment 534566 [details] [diff] [review]
Patch that moves CSS style from template to style.css (v3)

Looks great! :-)

Comment 10

[David Lawrence [:dkl]]

Thanks

trunk:
Committing to: bzr+ssh://[e-mail]/bugzilla/trunk
modified extensions/Voting/template/en/default/hook/bug/edit-after_importance.html.tmpl
modified extensions/Voting/web/style.css
Committed revision 7826.

dkl