658259 - Incorrect function tested in browser/components/sessionstore/test/browser/browser_345898.js

Status: RESOLVED FIXED

(Firefox :: Session Restore, defect)

Description

[Alastair Robertson]

User-Agent:       Mozilla/5.0 (X11; Linux x86_64; rv:2.0.1) Gecko/20110429 Firefox/4.0.1
Build Identifier: Mozilla/5.0 (X11; Linux x86_64; rv:2.0.1) Gecko/20110429 Firefox/4.0.1

Line 77 in browser/components/sessionstore/test/browser/browser_345898.js tests getWindowValue, but the error message refers to setWindowValue.
It should probably be setWindowValue that is tested, as that function is not tested anywhere else in browser_345898.js

Reproducible: Always

Comment 1

[Alastair Robertson]

Also, the tests on lines 73 and 75 are identical, which is a little odd.

Comment 2

[Matt Brubeck (:mbrubeck)]

Attachment: patch

Comment 3

[Matt Brubeck (:mbrubeck)]

Pushed to Try: http://tbpl.mozilla.org/?tree=Try&rev=90523db6b0be

Comment 4

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Comment on attachment 533667 [details] [diff] [review]
patch

Review of attachment 533667 [details] [diff] [review]:
-----------------------------------------------------------------

Alastair: thanks for catching that!
Matt: thanks for the quick fix :)

Comment 5

[Matt Brubeck (:mbrubeck)]

Pushed to Try again, on more platforms: http://tbpl.mozilla.org/?tree=Try&rev=667f483f1b3f

This is green on all platforms; I'll push it to m-c tomorrow.

Comment 6

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Bug 606681 is ready to go too (and might have a small context conflict). If you want to land that with this, that would be great. Otherwise I can land them.

Comment 7

[Matt Brubeck (:mbrubeck)]

I can land both patches today.

Comment 8

[Matt Brubeck (:mbrubeck)]

http://hg.mozilla.org/mozilla-central/rev/0cfa66a223ab