Closed Bug 658275 Opened 13 years ago Closed 13 years ago

browser_globalinformations.js should not require the network

Categories

(Toolkit :: Add-ons Manager, defect)

Product:
Toolkit
Component:
Add-ons Manager
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla6

People

(Reporter: mossop, Assigned: peregrino)

References

Details

Attachments

(1 file)

proposed patch
946 bytes, patch
mossop
: review+
Details | Diff | Splinter Review 
I missed this in the review of bug 656269. As a rule tests shouldn't depend on things on the network in order to pass and currently we depend on being able to load the plugin check page during the test run. We should instead set a dummy url to the pref pointing to the local test server, this will probably speed up the test too.
Attached patch proposed patch — — Splinter Review 

        Attachment #533720 -
        Flags: review?(dtownsend)

    
  

        Attachment #533720 -
        Flags: review?(dtownsend) → review+

    
    

    
  
Landed: http://hg.mozilla.org/mozilla-central/rev/058f05dd5d02
Status: NEW → RESOLVED
Closed: 13 years ago
Flags: in-testsuite-
Flags: in-litmus-
Resolution: --- → FIXED
Target Milestone: --- → mozilla6

    
    

    
  
Verified fixed by check-in (merge) on mozilla-aurora.
Status: RESOLVED → VERIFIED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: