Closed
Bug 658322
Opened 13 years ago
Closed 13 years ago
Use elmo-lib as a submodule in vendor-local
Categories
(Webtools Graveyard :: Elmo, defect, P2)
Webtools Graveyard
Elmo
Tracking
(Not tracked)
RESOLVED
FIXED
1.2
People
(Reporter: stas, Assigned: stas)
References
Details
Attachments
(1 file)
2.07 KB,
patch
|
Pike
:
review+
|
Details | Diff | Splinter Review |
The advantages would be: - we can easily add other non-compiled dependencies to vendor - we don't risk that upstream changes to playdoh-lib break our code when we do 'git submodule update'
Assignee | ||
Updated•13 years ago
|
Assignee: nobody → stas
Status: NEW → ASSIGNED
Assignee | ||
Updated•13 years ago
|
Priority: -- → P2
Assignee | ||
Comment 1•13 years ago
|
||
Here's another idea: - leave playdoh-lib in vendor/ - add elmo-lib in vendor-local/ (which has precedence in manage.py)
Assignee | ||
Comment 2•13 years ago
|
||
Here a patch implementing the vendor-local approach. I created https://github.com/mozilla/elmo-lib, too. I edited the update_script.py script to entirely rely on --recursive. I don't think it's a good think to do 'git pull' inside the vendor[-local] submodule manually, as that can pull in more recent commits than the one registered as the submodule. That looks lke a playdoh bug to me.
Attachment #535239 -
Flags: review?(peterbe)
Updated•13 years ago
|
Attachment #535239 -
Flags: review?(peterbe) → review+
Assignee | ||
Comment 3•13 years ago
|
||
Pushed: https://github.com/mozilla/elmo/commit/c588fe2174b4d644d202cf596fb41cadd226c0dd Please pull with `git pull && git submodule update --init --recursive`
Assignee | ||
Updated•13 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.2
Assignee | ||
Comment 4•13 years ago
|
||
Adjusting the summary to what has been done.
Summary: Use elmo-lib instead of playdoh-lib for vendor/ → Use elmo-lib as a submodule in vendor-local
Updated•4 years ago
|
Product: Webtools → Webtools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•