658363 - MOVE DEFINES FOR DOUBLE CONSTANTS OUT OF XSLT

Status: RESOLVED FIXED

(Core :: XSLT, defect)

Description

[Trevor Saunders (:tbsaunde)]

User-Agent:       Mozilla/5.0 (X11; Linux x86_64; rv:6.0a1) Gecko/20110518 Firefox/6.0a1
Build Identifier: 

XSLT has some defines for doubles that would be useful outside of xslt

Reproducible: Always

Comment 1

[Trevor Saunders (:tbsaunde)]

Attachment: patch

first shot, there's a lot more random basic runtimey code in xslt/src/base that should go away eventually, but this atleast makes it smaller.

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 533763 [details] [diff] [review]
patch

Looks good to me!

Comment 3

[Trevor Saunders (:tbsaunde)]

landed on mozilla-central hg.mozilla.org/mozilla-central/rev/2b53d3079c78
/TMP/LINK

Comment 4

[Landry Breuil (:gaston)]

Fwiw, it looks there's a typo in the commit, line 56 of txDouble.cpp there's still a 'txdpun' type used, and this broke builds on at least OpenBSD/sparc64, as can be seen on http://buildbot.rhaalovely.net/builders/comm-central-sparc64/builds/25/steps/build/logs/stdio

/var/buildslave/comm-central-sparc64/build/mozilla/content/xslt/src/base/txDouble.cpp:56: error: 'txdpun' does not name a type
/var/buildslave/comm-central-sparc64/build/mozilla/content/xslt/src/base/txDouble.cpp:56: error: extra ';'

I guess s/txdpun/dpun/ fixes it, will test. Reopening in the meantime.

Comment 5

[Landry Breuil (:gaston)]

Attachment: Fix probable typo

Here's the hg patch i'm testing

Comment 6

[Trevor Saunders (:tbsaunde)]

(In reply to comment #5)
> Created attachment 536163 [details] [diff] [review] [review]
> Fix probable typo
> 
> Here's the hg patch i'm testing

yeah, looks like  I missed a spot when I grepped for uses, sorry about that.

Comment 7

[Landry Breuil (:gaston)]

The patch fixes the build for me. (well, make package still chokes with bus error on sparc64, but that's another story)

Comment 8

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 536163 [details] [diff] [review]
Fix probable typo

Thanks!

Comment 9

[Trevor Saunders (:tbsaunde)]

LANDED http://hg.mozilla.org/mozilla-central/rev/61e6c962123c