Closed Bug 658383 Opened 13 years ago Closed 13 years ago

Location bar "Go" button is not subject to the javascript: URL security changes in bug 656433

Categories

(Firefox :: Address Bar, defect)

x86
macOS
defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 6

People

(Reporter: jruderman, Assigned: Gavin)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

(split from bug 658220)
Attached patch patch (obsolete) — Splinter Review
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Attachment #533818 - Flags: review?(dao)
Comment on attachment 533818 [details] [diff] [review]
patch

>+          function loadCurrent(url, postData) {
>+            // Pass LOAD_FLAGS_DISALLOW_INHERIT_OWNER to prevent any loads from
>+            // inheriting the currently loaded document's principal.
>+            let flags = Ci.nsIWebNavigation.LOAD_FLAGS_ALLOW_THIRD_PARTY_FIXUP |
>+                        Ci.nsIWebNavigation.LOAD_FLAGS_DISALLOW_INHERIT_OWNER;
>+            gBrowser.loadURIWithFlags(url, flags, null, null, postData);
>+          }

>+              loadCurrent(url, postData);

>+            loadCurrent(url, postData);

It looks like url and postData are already in loadCurrent's scope and don't need to be passed in.
Attachment #533818 - Flags: review?(dao) → review+
Attached patch updated patchSplinter Review
Attachment #533818 - Attachment is obsolete: true
http://hg.mozilla.org/mozilla-central/rev/e5663e0e20b3
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Flags: in-testsuite+
Target Milestone: --- → Firefox 6
Depends on: 672813
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:6.0) Gecko/20100101 Firefox/6.0

Verified issue on Mac OS X 10.6. "Go" button is no longer a subject to the javascript: URL.

Setting resolution to VERIFIED FIXED.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: