Closed
Bug 658505
Opened 13 years ago
Closed 13 years ago
removal of thread synchronization when setting a prototype
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: igor, Assigned: igor)
Details
(Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file)
|
3.98 KB,
patch
|
jorendorff
:
review+
|
Details | Diff | Splinter Review |
Currently we still use the GC machinery to get an exclusive access to the prototype chain when setting a prototype. I suggest to remove that. The only drawback AFAICS is that it would be not possible to implement a thread-shared object with script-mutable prototype. But given the current plans it is rather unlikely that we would need to support such object.
|
Assignee | |
Comment 1•13 years ago
|
||
Straightforward implementation
Assignee: general → igor
Attachment #533953 -
Flags: review?(jorendorff)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 533953 [details] [diff] [review] v1 Looks perfect. Thanks.
Attachment #533953 -
Flags: review?(jorendorff) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
http://hg.mozilla.org/tracemonkey/rev/dbe681ddbd5b
Whiteboard: fixed-in-tracemonkey
|
||
Comment 4•13 years ago
|
||
cdleary-bot mozilla-central merge info: http://hg.mozilla.org/mozilla-central/rev/dbe681ddbd5b
|
|
||
Updated•13 years ago
|
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•