Closed
Bug 658725
Opened 13 years ago
Closed 13 years ago
NS_EXTERNALSHARINGAPPSERVICE_CID value is wrong and fail to compile
Categories
(Core Graveyard :: File Handling, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla7
People
(Reporter: romaxa, Assigned: romaxa)
References
Details
Attachments
(1 file)
665 bytes,
patch
|
dougt
:
review+
|
Details | Diff | Splinter Review |
http://hg.mozilla.org/mozilla-central/rev/5176c8f2691e#l6.50 6.48 +#define NS_EXTERNALSHARINGAPPSERVICE_CID \ 6.49 + {0xea782c90, 0xc6ec, 0x11df, \ 6.50 + {0xbd3, 0x08, 0x00, 0x20, 0x0c, 0x9a, 0x66, 0x74}} ^ - this is wrong
Attachment #534177 -
Flags: review?(doug.turner)
Comment 1•13 years ago
|
||
How did this ever work? when I reviewed Tero's patch, i assumed that it had basic testing.
Assignee | ||
Comment 3•13 years ago
|
||
I guess it did work before somehow by ignoring wrong value with compile warning...
Updated•13 years ago
|
Attachment #534177 -
Flags: review?(doug.turner) → review+
Updated•13 years ago
|
Keywords: checkin-needed
Updated•13 years ago
|
Assignee: nobody → doug.turner
Comment 4•13 years ago
|
||
Can you _please_ add metadata to things you want others to push for you? :(
Updated•13 years ago
|
Assignee: doug.turner → romaxa
Comment 5•13 years ago
|
||
good idea. might start requiring that on patches. also, bzimport looks like it barfed on this patch: hg qimport bz://658725 and hg out changeset: 70002:8e53a8d44a83 tag: 658725 tag: qtip tag: tip user: Oleg Romashin <romaxa> date: Fri May 20 18:07:00 2011 -0700 summary: imported patch 658725
Comment 6•13 years ago
|
||
Fwiw, I did push this to cedar: http://hg.mozilla.org/projects/cedar/rev/10bfe807438c But yes, patches with no commit info from someone who should know better should just get r-.
Keywords: checkin-needed
Whiteboard: fixed-in-cedar
Comment 7•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/10bfe807438c
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: fixed-in-cedar
Target Milestone: --- → mozilla7
Comment 8•13 years ago
|
||
Can anyone please provide some guidelines that I can use to verify this fix? Do I need to create any specific environment to test it? Thanks!
Comment 9•13 years ago
|
||
Verified the file uriloader/exthandler/unix/nsExternalSharingAppService.h in mozilla-central and changes mentioned in comment 7 are submitted. Changing resolution to VERIFIED-FIXED
Status: RESOLVED → VERIFIED
Updated•8 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•