Open
Bug 658842
Opened 13 years ago
Updated 10 months ago
PopupNotifications look bad of labels too long
Categories
(Toolkit :: PopupNotifications and Notification Bars, defect)
Toolkit
PopupNotifications and Notification Bars
Tracking
()
NEW
People
(Reporter: ignisvulpis, Unassigned)
References
Details
(Whiteboard: [doorhanger][bugday-2011-05-27])
Attachments
(4 files, 1 obsolete file)
User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:2.0.1) Gecko/20100101 Firefox/4.0.1 openid Build Identifier: Mozilla/5.0 (Windows NT 5.1; rv:2.0.1) Gecko/20100101 Firefox/4.0.1 if the labels are too long (>32) the dropdown menu looks bad. The popupnotification grows to accommodate the long labels but the dropdown menu is not right aligned animore. It moves to to the left it appears and moves over the popupnotification icon cluttering it. Reproducible: Always Steps to Reproduce: 1. Create a Popupnotification with long labels and show it 2. 3. Actual Results: see Details Expected Results: The popupnotification window should grow and the dropdown should be right aligned in this window.
Reporter | ||
Comment 1•13 years ago
|
||
Comment 2•13 years ago
|
||
Is your Issue reproducible in Safe-Mode? https://support.mozilla.com/en-US/kb/Safe+Mode
Version: unspecified → 4.0 Branch
Reporter | ||
Comment 3•13 years ago
|
||
I need an addon to generate the long labels; so safe-mode is not an option I think. Do you know a way to generate a popupnotification with long labels in the secondary options? I use my addon "openid for firefox". After I used this openids "yahoo.com" and "https://www.google.com/accounts/o8/id" at an openid consumer e.g. http://wiki.idcommons.net/Special:OpenIDLogin the addon stored the long openid returned be the openid providers yahoo and google. Then I ctrl-click the openid icon in the urlbar. This makes the ugly popupnotification appear. Although it is not impossible that "openid for firefox" is the culprit I guess that long labels just weren't ever tested. "openid for firefox" is here https://addons.mozilla.org/en-US/firefox/addon/openid-for-firefox/ . I'll attach my current version to this bug report.
Reporter | ||
Comment 4•13 years ago
|
||
Comment 5•13 years ago
|
||
Ah yes. Indeed I'd guess that the Labels were designed to offer short texted Choices only.
Blocks: doorhanger
OS: Windows XP → All
Hardware: x86 → All
Whiteboard: [doorhanger]
Version: 4.0 Branch → Trunk
Reporter | ||
Comment 6•13 years ago
|
||
The window/popup is getting wider to the right but the drop-down menu is too much to the left. Don't know how the position of the drop-down menu is computed. Anyways, if the width of the labels is constraint then there should be a crop option I think.
OS: All → Windows XP
Hardware: All → x86
Version: Trunk → 4.0 Branch
Updated•13 years ago
|
OS: Windows XP → All
Hardware: x86 → All
Version: 4.0 Branch → Trunk
Reporter | ||
Comment 7•13 years ago
|
||
My guess is that the error is here: http://mxr.mozilla.org/mozilla-central/source/toolkit/content/widgets/notification.xml#422 Do the attributes 'pack="end" align="center"' make sense on a hbox with exactly one child element the button? http://mxr.mozilla.org/mozilla-central/source/toolkit/content/widgets/notification.xml#430 These attributes force the children in the box to be packed to the right but not the box itself. Maybe this hbox needs to be inside an additional hbox which has 'pack="end"'.
Can I test this if I do not have an OpenID created?
Component: General → XP Toolkit/Widgets: Menus
Product: Firefox → Core
QA Contact: general → xptoolkit.menus
Whiteboard: [doorhanger] → [doorhanger][bugday-2011-05-27]
Reporter | ||
Comment 9•13 years ago
|
||
To test this you need a way to create a PopupNotification with long labels. This can be done with any addon. If you use openid.xpi to test this then you need an openid e.g. a google profile or an Yahoo! account. Here is a list of openid providers: https://openid.net/get-an-openid/ where you can get openids for you. A script to test this might look similar to the following code. But maybe this bug's behavior only shows when there are secondary options?! Don't knot yet. file bug658842.js: ... Components.utils.import("resource://gre/modules/PopupNotifications.jsm", tmp); var pop = new tmp.PopupNotifications(gBrowser, document.getElementById("notification-popup"), document.getElementById("notification-popup-box")); var anchorId = "openid-nascar-url-bar-image"; pop.show(gBrowser.selectedBrowser, "org-openinfocard-openid", "This popup shows a long label", anchorId, { label: "This is a long label that helps you see what this bug 658842 is all about", accessKey: "S", callback: function() { alert("The callbacks should have the menuitem as a parameter. Change Request!"); } }, null, /* secondary action */ null /* options */ ); ... file style.css: #notification-popup-box[anchorid="openid-nascar-url-bar-image"] > #openid-notification-icon { display: -moz-box; } #openid-notification-icon { list-style-image: url(chrome://openidnascar/content/openid-16x16.gif); } .popup-notification-icon[popupid="org-openinfocard-openid"] { list-style-image: url(chrome://openidnascar/content/openid-icon-100x100.png); } Would be nice if we had a minimal xpi to show this bug. This would then possibly show that I did every right in the attached openid.xpi. So I think it would be best if not I write that bug658842.xul, bug658842.js etc Yesterday I removed Popupnotifications from my code because of this bug and now I use my own panel to show the openids. I will upload this version to AMO soon.
Comment 10•13 years ago
|
||
Whould it be possible for you to make an addon that works without any OpenID? Addon that just opens the notification with some random long string?
Reporter | ||
Comment 11•13 years ago
|
||
The image was produced using the openid.xpi that I will upload in a minute. Cntrl-clicking the openid icon in the urlbar will produce the bad popup.
Reporter | ||
Comment 12•13 years ago
|
||
Comment 13•13 years ago
|
||
Confirming with the test addon.
Attachment #534299 -
Attachment is obsolete: true
Comment 14•10 years ago
|
||
Mass-move to Toolkit::Notifications and Alerts Filter on notifications-and-alerts-component.
Component: XP Toolkit/Widgets: Menus → Notifications and Alerts
Product: Core → Toolkit
Version: Trunk → unspecified
Updated•2 years ago
|
Severity: normal → S3
Updated•10 months ago
|
Component: Notifications and Alerts → PopupNotifications and Notification Bars
You need to log in
before you can comment on or make changes to this bug.
Description
•