658872 - Move the splitter on top of the FormatToolbar

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[Richard Marti (:Paenglab)]

In Bug 654754 Comment 13 bwinton sayd:

> And I would still prefer to see the splitter on top of the FormatToolbar,
> but we can leave that for another bug, I guess…

This makes sense because the splitter changes the height of the addressing widget and the FormatToolbar is more associated to the text content.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: Move the splitter

This patch moves the splitter above the FormatToolbar.

Under Win7 I gave the tool bar a 1px top border because the splitter is invisible (mouse pointer still changes). If needed I can make it 2px high.

Comment 2

[rsx11m]

> This makes sense because the splitter changes the height of the addressing
> widget and the FormatToolbar is more associated to the text content.

On the other hand, one could argue that the splitter determines the ratio between the header pane and the message pane in the composition window, which is allocated to the address rows. This was probably the thinking when initially implementing it in the current way.

On the other other hand, the formatting toolbar can be considered part of the message, thus moving the splitter on top of it makes equally sense.  :-)

> I gave the tool bar a 1px top border because the splitter is invisible

Wasn't the active height made 3px somewhere for better accessibility or is this not touched by your patch? Grabbing 1px with the mouse may be tricky for some.

Comment 3

[Richard Marti (:Paenglab)]

(In reply to comment #2)
> Wasn't the active height made 3px somewhere for better
> accessibility or is this not touched by your patch? Grabbing 1px
> with the mouse may be tricky for some.

My description was unclear. The splitter is still 4px heigh but isn't visible with a different color. Actually in TB 3.4 under Win7 you see only the border between the header box and the message. The splitter has still his 4px space. The border on top of the FormatToolbar copies only this behavior.

Comment 4

[Andreas Nilsson (:andreasn)]

I think this change makes sense, but I had issues getting it to work on my system (I think). Could you provide some screenshots of how it's supposed to look like?

Comment 5

[Richard Marti (:Paenglab)]

Attachment: Patch in action under Win7

Screenshot of patch in action under Win7 Aero and Classic

Comment 6

[Andreas Nilsson (:andreasn)]

Comment on attachment 534293 [details] [diff] [review]
Move the splitter

Based on the screenshots (sorry, build still broken), ui-r+ from me

Comment 7

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 534293 [details] [diff] [review]
Move the splitter

Review of attachment 534293 [details] [diff] [review]:
-----------------------------------------------------------------

Other than the change I mention below (and the other instances of that change), I think I like this patch, so r=me with either that change made, or a good explanation of why you can't and why it's not so bad.  ;)

Thanks,
Blake.

::: mail/components/compose/content/messengercompose.xul
@@ +87,4 @@
>  .toolbarbutton-menubutton-button,
>  .toolbarbutton-menubutton-dropmarker,
>  .toolbarbutton-1,
> +menulist {

That seems like a far-reaching change…  Are you sure you don't want to change it to "#FormatToolbox menulist" instead?

Comment 8

[Richard Marti (:Paenglab)]

It would not only need a "#FormatToolbar menulist", also a "#addresses-box menulist". Because messengercompose.css affects only the messengercompose window I thought, I can use such a wide rule.

If you still decide I should add these stronger rules, I'll them.

Comment 9

[Blake Winton (:bwinton) (:☕️)]

(In reply to comment #8)
> It would not only need a "#FormatToolbar menulist", also a "#addresses-box
> menulist". Because messengercompose.css affects only the messengercompose
> window I thought, I can use such a wide rule.
> 
> If you still decide I should add these stronger rules, I'll them.

No, that's a good explanation of why you don't want to, and why it's not so bad.  :)  The r=me stands.

Later,
Blake.

Comment 10

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/585da56d82a4