658904 - Remove nsIDOMDocumentStyle

Status: VERIFIED FIXED

(Core :: DOM: CSS Object Model, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 534321 [details] [diff] [review]
Patch v1

Review of attachment 534321 [details] [diff] [review]:
-----------------------------------------------------------------

I am not a content peer so this needs additional review from someone who is.

::: dom/interfaces/core/nsIDOMDocument.idl
@@ +217,1 @@
>  };

nsIDOMDocument needs an IID rev.

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Yes, will do (and its subclasses as well).

Comment 3

[Johnny Stenback (:jst)]

Comment on attachment 534321 [details] [diff] [review]
Patch v1

r=jst, but yeah, rev the IID for nsIDOMDocument, and also for other interfaces that directly or indirectly inherit nsIDOMDocument (nsIDOMHTMLDocument, nsIDOMXMLDocument, and nsIDOMSVGDocument), just because they tend to be interfaces that are very commonly used by binary extensions etc.

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

http://hg.mozilla.org/mozilla-central/rev/08d91c51adb5

Comment 5

[Tom Hindle]

The actual file nsIDOMDocumentCSS.idl doesn't seem to have been deleted?

Comment 6

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Indeed. I'll remove it when I next need to push.

Comment 7

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Or actually, Ed is going to in bug 667021.

Comment 8

[Tom Hindle]

Thanks - I wasn't nit-picking, I have a idl -> C# compiler which couldn't compile that file.

Comment 9

[Trif Andrei-Alin[:AlinT]]

It seems to have been removed after seeing the bug in comment 7.
Setting resolution to VERIFIED FIXED.
Thanks.