659071 - Ctrl + scrollwheel doesn't zoom when hovering a <video> element

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Daniel Holbert [:dholbert]]

STR:
 1. Load video w/ embedded <video>, e.g. http://tinyvid.tv/show/q31g9htvwjdh
 2. Position cursor over page background.
 3. Ctrl-Scrollwheel
     --> Page zooms in/out
 4. Position cursor over <video> element
 4. Ctrl-Scrollwheel
     --> Page DOES NOT ZOOM
 5. Ctrl-+
     --> Page zooms in/out

ACTUAL RESULTS: Scrollwheel zoom is broken when cursor is above a <video>.


NOTE: Flash videos don't have this problem -- e.g. Ctrl-scrollwheel zooms just fine when I hover the video at http://www.youtube.com/watch?v=7FOydLkHQmw (without experimental-html5-video-opt-in)

Comment 1

[Daniel Holbert [:dholbert]]

Version info:
Mozilla/5.0 (X11; Linux x86_64; rv:6.0a1) Gecko/20110522 Firefox/6.0a1

This bug also reproduces when you're viewing a video directly, too -- e.g. I can repro it here:   http://media.tinyvid.tv/q31g9htvwjdh.ogg

Comment 2

[Chris DeCairos (:cade)]

The problem is here:

http://mxr.mozilla.org/mozilla-central/source/content/events/src/nsEventStateManager.cpp#2514

if (content &&
    !content->IsNodeOfType(nsINode::eHTML_FORM_CONTROL) &&
    !content->IsXUL())
  {

!content->IsXUL() returns false when content is a <audio> or <video> element

Comment 3

[Chris DeCairos (:cade)]

So it looks like the problem is the controls of the audio and video element. When they are visible and you try to zoom in using the scroll wheel over one of the elements, the controls become the "content" parameter I mentioned in comment 2. 

Not sure wht the best solution is. we could add a special condition to the if statement up there for media elements, or we could somehow get the event to ignore the controls and get the video frame as content

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Shouldn't we check whether the document is XUL?

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Yeah. I think that shouldn't be !content->IsXUL() but
!content->OwnerDoc()->IsXUL()

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Thanks, I'll fix this after bug 719320.

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch

If the test is performed in the iframe of the harness, some tests after it will fail :-(

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/823ee7ad3411

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/823ee7ad3411