659207 - --enable-shared-js builds are broken

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P1)

Description

[Boris Zbarsky [:bzbarsky]]

Actually, any build that tries to use js::ForceFrame without statically linking JS, because the destructor is inline but uses non-exported stuff.

This broke all my builds, for example.  :(

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Don't inline a constructor that consumers can't actually inline without statically linking to JS.

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 534648 [details] [diff] [review]
Don't inline a constructor that consumers can't actually inline without statically linking to JS.

It makes me sad that this is necessary.

Comment 3

[Mounir Lamouri (:mounir)]

Pushed:
http://hg.mozilla.org/mozilla-central/rev/837f762860af

Comment 4

[Benjamin Smedberg]

No need to track: release drivers are conflicted on whether we'd take a patch which doesn't affect our release builds on the beta channel...

Comment 5

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 534648 [details] [diff] [review]
Don't inline a constructor that consumers can't actually inline without statically linking to JS.

I think we should take this for beta.

Comment 6

[LegNeato]

This doesn't apply cleanly to mozilla-beta. Rescinding approval as we are late in beta anyway.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Um... Making this apply cleanly is a trivial merge, which I was going to do on Monday.

Either way, though.  I guess it doesn't matter that much if our beta and fx5 can't be built in some supported configurations....