65937 - Pressing Create Profile gives JavaScript error in console

Status: VERIFIED FIXED

(SeaMonkey :: Startup & Profiles, defect)

Description

[Henrik Gemal]

If you start the profile manager with the console and javascript strict option 
on, when you press the Create Profile.. button the console says:

JavaScript error:
chrome://global/content/wizardHandlerSet.js line 157: controls has no properties

Comment 1

[prass]

Attachment: workaround for js error in wizards

Comment 2

[Ben Goodger (use ben at mozilla dot org for email)]

if ("controls" in document) {

}

is better than if (document.controls) and avoids a js warning

otherwise, a=[e-mail]

Comment 3

[prass]

Attachment: Patch with Ben's suggestion

Comment 4

[Blake Ross]

Modified patch checked in.  Thanks.

Comment 5

[Brendan Eich [:brendan]]

That last patch has tabs where it should not.

Super-style nit: doesn't if ('controls' in doc) set the property name off from
other (non-property-name) strings, which normally use "" rather than ''?  '' is
equivalent in JS, provided for two-level quote nesting only, but stylistically
useful to make keywords and identifiers stand out from mundane strings.  Just a
thought.

/be

Comment 6

[Blake Ross]

The fix I checked in fixed those nits.

Comment 7

[Grace Bush]

verified in build 2000020904