659447 - Tweaks to Firefox Gingerbread UI

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Ian Barlow (:ibarlow)]

Attachment: Website info menu tweaks

Comments on latest Nightly build from May 24

Left tab bar
* Update tab background assets (there should be no gradients in them)
* Replace close button assets with new assets provided here

Website info dropdown
Update UI as per attached mock:
* Move Larry and text down to align with lock
* Move text right to align with URLbar text
* Center Larry horizontally between left edge and text
* Update menu selection background

Comment 1

[Ian Barlow (:ibarlow)]

Attachment: Updated assets for Gingerbread UI

Comment 2

[Aaron Train [:aaronmt]]

#8db8d8 is used in the Gingerbread theme and in these rules, is this still desired? It seems out of place now.

http://mxr.mozilla.org/mozilla-central/source/mobile/themes/core/platform.css#51
http://mxr.mozilla.org/mozilla-central/source/mobile/themes/core/platform.css#436
http://mxr.mozilla.org/mozilla-central/source/mobile/themes/core/platform.css#548

Comment 3

[Ian Barlow (:ibarlow)]

Hi Aaron, I would be happy to go to the light grey we're using elsewhere, #D6D6D6, or to use the same background image we are using in our popup menus, popup-selected-item-hdpi.png (which is also grey)

Comment 4

[Ian Barlow (:ibarlow)]

Attachment: Updated Lock assets for site info menu

These new borderless lock images should fix our alignment troubles

Comment 5

[Ian Barlow (:ibarlow)]

Attachment: Assets for Preferences

Included here are a dropdown button, radio buttons, and an "update addons" button!

Comment 6

[Ian Barlow (:ibarlow)]

Also, here is where we ended up with the Add-ons page update (which will change a bit once we have a discopane) http://www.cl.ly/190c2G3y3Q411M3A3E18

Comment 7

[Aaron Train [:aaronmt]]

Attachment: Tap hold selection

Blue tap hold selection color in Gingerbread theme

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #7)
> Created attachment 535988 [details]
> Tap hold selection
> 
> Blue tap hold selection color in Gingerbread theme

Can you file a new bug for this?

Comment 9

[Mark Finkle (:mfinkle) (use needinfo?)]

fixed as part of bug 612193 except for:

* Move text right to align with URLbar text
* Center Larry horizontally between left edge and text

which I didn't do because the alignment of the larry text to the URL text seemed very weak, considering the URL text could shift with an add-on and would have meant we needed to move the larry text to the right. But we already are short on space for the full identification text for long addresses as it is.

Anyhow, we can file a new bug just for that if we really want it.

Comment 10

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Verified all but the highlight and the justification of the Larry due to comment 8 and comment 9:
Mozilla/5.0 (Android; Linux armv71; rv6.0a2) Gecko/20110623 Firefox/6.0a2 Fennec/6.0a2
Device: HTC Flyer
OS: Android 2.3