Closed Bug 659529 Opened 13 years ago Closed 13 years ago

Package name should be stored in revision

Categories

(addons.mozilla.org Graveyard :: Add-on Builder, defect, P1)

Product:
addons.mozilla.org Graveyard
Component:
Add-on Builder
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Builder 0.9.6

People

(Reporter: smcarthur, Assigned: zalun)

Details

If an Addon or Library includes another library as a dependency, it can do require('library/module'). With the name being stored in the package, it's possible for the library owner to change the name, and it will break all users using the package name in the require statements.

Instead, the name should be saved into the revision, so that way if the owner ever changes the name, it wont change for users of that library until they update to the newest revision.
Assignee: nobody → zaloon
Severity: normal → major
Priority: -- → P1
Target Milestone: --- → Builder 0.9.6
Severity: major → blocker
Done - https://github.com/mozilla/FlightDeck/commit/7126afcbc0463275a4cc2021da91a53893299f5d

There is still a need to change the updated dependency name after it's name been changed and updated to the latest version. This wasn't working before. I marked it with XXX in Sidebar.js
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.