Closed
Bug 659591
Opened 13 years ago
Closed 13 years ago
Fire SSWindowClosing when session store handles a closing window (on domwindowclosed)
Categories
(Firefox :: Session Restore, defect)
Firefox
Session Restore
Tracking
()
RESOLVED
FIXED
Firefox 7
People
(Reporter: ttaubert, Assigned: ttaubert)
References
Details
Attachments
(1 file, 1 obsolete file)
2.73 KB,
patch
|
zpao
:
review+
|
Details | Diff | Splinter Review |
From bug 655269 comment #7: So we should probably do like what we do for tabs (SSTabClosing), which is fired at the beginning of sessionstore processing the TabClose event. We can add SSWindowClosing.
Assignee | ||
Comment 1•13 years ago
|
||
Assignee | ||
Comment 2•13 years ago
|
||
Comment on attachment 535038 [details] [diff] [review] patch v1 Passed try: http://tbpl.mozilla.org/?tree=Try&pusher=tim.taubert@gmx.de&rev=b11596fb0686
Assignee | ||
Comment 3•13 years ago
|
||
Attachment #535038 -
Attachment is obsolete: true
Attachment #535038 -
Flags: review?(paul)
Attachment #537155 -
Flags: review?(paul)
Comment 4•13 years ago
|
||
Comment on attachment 537155 [details] [diff] [review] patch v2 Review of attachment 537155 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/components/sessionstore/test/browser/browser_659591.js @@ +6,5 @@ > + > + newWindow(function (win) { > + win.addEventListener("SSWindowClosing", function onWindowClosing() { > + win.removeEventListener("SSWindowClosing", onWindowClosing, false); > + waitForFocus(finish); Let's make is so there's actually a test that passes. Have a variable (gotEvent or something) defaulted to false. Set to true in the SSWindowClosing handler, then register a cleanup function that checks ok(gotEvent). That way we'll at least have a passing test and if it fails, it won't just be a timeout, we'll actually see a failed test.
Attachment #537155 -
Flags: review?(paul) → review+
Assignee | ||
Comment 5•13 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/a1b563094e5a
Whiteboard: [inbound]
Assignee | ||
Comment 7•13 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/92f4836116a3
Whiteboard: [inbound]
Comment 8•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/92f4836116a3
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → Firefox 7
You need to log in
before you can comment on or make changes to this bug.
Description
•