659621 - Remove EXTRA_DSO_LDOPTS, EXTRA_DSO_LIBS and OS_LIBS, now that libxul always built

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Ed Morley [:emorley]]

Remove all of:
http://mxr.mozilla.org/mozilla-central/search?string=gkgfx

Apart from:
http://mxr.mozilla.org/mozilla-central/source/gfx/src/Makefile.in#47
http://mxr.mozilla.org/mozilla-central/source/toolkit/library/libxul-config.mk#128

Comment 1

[Mike Hommey [:glandium]]

I think you can completely remove EXTRA_DSO_LDOPTS, EXTRA_DSO_LIBS and OS_LIBS from any Makefile.in where LIBXUL_LIBRARY = 1.

Comment 2

[Ed Morley [:emorley]]

Sounds like a plan, morphing.

Comment 3

[Ed Morley [:emorley]]

Attachment: Remove EXTRA_DSO_LIBS, EXTRA_DSO_LDOPTS, OS_LIBS from makefiles containing LIBXUL_LIBRARY = 1

http://dev.philringnalda.com/tbpl/?tree=Try&rev=c2798493e31f

(The b-s repo does not yet contain the bug 648911 changes, so I decided to base this off of m-c for now, to make it easier to rebase on b-s later, once it merges with m-c).

Comment 4

[Ed Morley [:emorley]]

Attachment: Remove EXTRA_DSO_LIBS, EXTRA_DSO_LDOPTS, OS_LIBS from makefiles containing LIBXUL_LIBRARY = 1

Typo fixed.

http://dev.philringnalda.com/tbpl/?tree=Try&rev=669aac8cadf5

Comment 5

[Ed Morley [:emorley]]

Comment on attachment 535170 [details] [diff] [review]
Remove EXTRA_DSO_LIBS, EXTRA_DSO_LDOPTS, OS_LIBS from makefiles containing LIBXUL_LIBRARY = 1

Passed try.

Thanks Ted :-)

Comment 6

[(not currently active) Ted Mielczarek]

Comment on attachment 535170 [details] [diff] [review]
Remove EXTRA_DSO_LIBS, EXTRA_DSO_LDOPTS, OS_LIBS from makefiles containing LIBXUL_LIBRARY = 1

Review of attachment 535170 [details] [diff] [review]:
-----------------------------------------------------------------

I really only skimmed this patch, but it looks good and it's 99% removals. If it passed try it should be fine.

Comment 7

[Ed Morley [:emorley]]

Attachment: Remove EXTRA_DSO_LIBS, EXTRA_DSO_LDOPTS, OS_LIBS from makefiles containing LIBXUL_LIBRARY = 1

Updated to build-system tip, no other changes, carrying forwards r+. Thanks Ted :-)

Ideally needs to land on build-system rather than m-c. Has passed try (comment 4), has author + commit message filled out.

Comment 8

[(not currently active) Ted Mielczarek]

http://hg.mozilla.org/projects/build-system/rev/2f965cea44ff

Comment 9

[(not currently active) Ted Mielczarek]

http://hg.mozilla.org/mozilla-central/rev/2f965cea44ff

Comment 10

[Simona Badau, Desktop QA]

Mozilla/5.0 (Windows NT 5.1; rv:7.0) Gecko/20100101 Firefox/7.0

Is there any way I can verify this on the QA side?

I checked and that all the files are removed from the repo.
http://hg.mozilla.org/mozilla-central/file/e0acef471ab2

Is that enough to mark this as VERIFIED FIXED?

Thanks!

Comment 11

[(not currently active) Ted Mielczarek]

This is just cleanup, it's not worth verifying. If you want to mark it VERIFIED, feel free, but it doesn't accomplish anything.

Comment 12

[Simona Badau, Desktop QA]

Based on Comment 11 marking this as VERIFIED FIXED.

Thanks!

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/88d84cad10c9
Remove EXTRA_DSO_LIBS, EXTRA_DSO_LDOPTS, OS_LIBS from makefiles containing LIBXUL_LIBRARY = 1, now that libxul is always built; r=ted