65969 - Long sidebar titles do not crop

Status: VERIFIED FIXED

(SeaMonkey :: Themes, defect, P2)

Description

[GAThrawn]

If you add a sidebar with a long title eg the one at
http://www.mydigiguide.com/, installable by clicking on the 'Add tab to netscape
6' button, and the bar is shorter than the title, it runs out into adjacent
chrome space. This only seems to happen on the Classic and not the Modern skin.

Steps to reproduce:
1 Open browser, make sure you're using Classic skin.
2 Go to the above URL and click the button to add the sidebar tab.
3 Move the new tab to the bottom of the list, and close it by selecting a
different tab on the sidebar.
4 Grab the vertical grippie on the sidebar and resize it so that it is smaller
than the tab's title.

Actual Result
The tab's title runs over into the adjacent chrome space (in this case the
Online/Offline indicator)

Expected Result
The tab's title is cropped to the available space

Reproducible on Win NT4 Mozilla 0.7, will try with newer build later on this
evening.

Comment 1

[Blake Ross]

-> hewitt

Comment 2

[GAThrawn]

Also happens with Mozilla build 20010117 Win 98SE.

Comment 3

[Joe Hewitt (gone)]

I have a fix, but it's definitely a hack.  In the XBL binding for sidebar tabs,
I had to put the text element inside a vertically-oriented box.  If the parent
of the text is horizontally-oriented, the text does not crop.

Ideally this hack wouldn't be needed.  Perhaps I'll file a separate bug against
layout.

Comment 4

[Joe Hewitt (gone)]

Attachment: patch to fix

Comment 5

[Blake Ross]

Any reason we explicitly want a vertical box?

Comment 6

[andreww]

r=andreww although this does sound hacky.  
Seems like we are depending on the  effect of some incorrect behavior which might 
change later.  But there are lots of other cases like this.

Comment 7

[Joe Hewitt (gone)]

Blake, there is no good reason to have a vertical box, other than because it
fixes this bug ;)  It's just a workaround.

Comment 8

[Blake Ross]

Do I hear mindless, illogical, nonsensical hackishness?

If so, r=blake

Comment 9

[Joe Hewitt (gone)]

fixed

Comment 10

[Patty Mac]

Verified on windows 98 (2001-03-26-09-Mtrunk).