659748 - jump bypasses variable initialization

Status: RESOLVED FIXED

(Core :: Security: PSM, defect)

Description

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: move the variable definition

nsNSSCertificateDB.cpp now fails to compile with clang because a goto jumps over

CERTValOutParam cvout[1];

Comment 1

[Kai Engert (:KaiE:)]

Comment on attachment 535172 [details] [diff] [review]
move the variable definition

>diff --git a/security/manager/ssl/src/nsNSSCertificateDB.cpp b/security/manager/ssl/src/nsNSSCertificateDB.cpp
>index dada28d..cb49fed 100644
>--- a/security/manager/ssl/src/nsNSSCertificateDB.cpp
>+++ b/security/manager/ssl/src/nsNSSCertificateDB.cpp
>@@ -562,6 +562,10 @@ nsNSSCertificateDB::ImportEmailCertificate(PRUint8 * data, PRUint32 length,
> 
>   numcerts = certCollection->numcerts;
> 
>+  // Note: This has to be defined before the first "goto loser", otherwise clang
>+  // will error saying: "jump bypasses variable initialization".

Comment not necessary


>+  CERTValOutParam cvout[1];

Please move this further up. Please move it to the section where all variables are declared, after the "int i".


>-  CERTValOutParam cvout[1];
>   cvout[0].type = cert_po_end;

Please move both lines.

Could you please make these changes?

Comment 2

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: updated patch

Comment 3

[Kai Engert (:KaiE:)]

Comment on attachment 535637 [details] [diff] [review]
updated patch

Review of attachment 535637 [details] [diff] [review]:
-----------------------------------------------------------------

r=kaie

Thanks

Comment 4

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/7fb970049952