Closed
Bug 659816
Opened 13 years ago
Closed 13 years ago
Quicksearch only works for ASCII strings (when quoted)
Categories
(Bugzilla :: Query/Bug List, defect)
Bugzilla
Query/Bug List
Tracking
()
RESOLVED
FIXED
Bugzilla 4.0
People
(Reporter: jruderman, Assigned: glob)
Details
Attachments
(1 file, 1 obsolete file)
|
680 bytes,
patch
|
mkanat
:
review+
|
Details | Diff | Splinter Review |
ALL su:⌘ https://bugzilla.mozilla.org/buglist.cgi?quicksearch=ALL%20su%3A%E2%8C%98 9 bugs ALL su:"⌘" https://bugzilla.mozilla.org/buglist.cgi?quicksearch=ALL%20su%3A%22%E2%8C%98%22 0 bugs :(
url_quote calls utf8::encode(), so we need to utf8::decode after calling url_decode.
Assignee: query-and-buglist → glob
Status: NEW → ASSIGNED
Attachment #535302 -
Flags: review?(mkanat)
|
||
Updated•13 years ago
|
Severity: major → minor
Target Milestone: --- → Bugzilla 4.0
|
|
||
Comment 2•13 years ago
|
||
Comment on attachment 535302 [details] [diff] [review] patch v1 Interestingly enough, this is the only code using url_decode. Let's modify url_decode instead of hacking a fix into Quicksearch.pm.
Attachment #535302 -
Flags: review?(mkanat) → review-
Attachment #535302 -
Attachment is obsolete: true
Attachment #535571 -
Flags: review?(mkanat)
|
|
||
Comment 4•13 years ago
|
||
Comment on attachment 535571 [details] [diff] [review] patch v2 If you've tested this, it looks okay to me. My concern is what happens if url_decode gets a string that's already tagged as utf8?
Attachment #535571 -
Flags: review?(mkanat) → review+
|
|
||
Updated•13 years ago
|
Flags: approval4.2+
Flags: approval4.0+
Flags: approval+
Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/ modified Bugzilla/Util.pm Committed revision 7828. Committing to: bzr+ssh://bjones%40mozilla.com@bzr.mozilla.org/bugzilla/4.0/ modified Bugzilla/Util.pm Committed revision 7601.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
OS: Mac OS X → All
Hardware: x86 → All
Resolution: --- → FIXED
|
||
Updated•13 years ago
|
Flags: approval4.2+
You need to log in
before you can comment on or make changes to this bug.
Description
•