660088 - OpenType sanitizer needs to handle 'name' table, not just replace it

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Jonathan Kew [:jfkthame]]

Attachment: patch, support the 'name' table in OTS

Currently, OTS discards the 'name' table and inserts a set of fixed name strings in all sanitized fonts. This prevents us returning the proper font name when querying the fonts actually used to render content (see bug 467669).

The attached patch fixes this by parsing and serializing the table, so that the font name is not lost during sanitization.

(When we're happy the patch is reasonable, we should submit it upstream to the OTS project.)

Comment 1

[Jonathan Kew [:jfkthame]]

I filed this as a feature request in the Chromium tracker, and have just attached the patch there as well to see what they do with it.

http://code.google.com/p/chromium/issues/detail?id=83706

Comment 2

[John Daggett (:jtd)]

Comment on attachment 535479 [details] [diff] [review]
patch, support the 'name' table in OTS

Code looks reasonable but as I mentioned on IRC I'm still not convinced that all this name table data is really necessary.  It seems like the only data that we currently would need is the fullname data but we're bringing in all name data fields.  But I'm guessing web font vendors are stripping a lot of name table entries so I guess we can adjust this later if it seems to be causing a problem.

Comment 3

[Jonathan Kew [:jfkthame]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/a4659906bcfb

Comment 4

[Jonathan Kew [:jfkthame]]

This was backed out along with bug 467669 in
http://hg.mozilla.org/integration/mozilla-inbound/rev/ed3cf3967b69

Comment 5

[Jonathan Kew [:jfkthame]]

And relanded on m-i:
http://hg.mozilla.org/integration/mozilla-inbound/rev/2d24929f1d65

Comment 6

[Mounir Lamouri (:mounir)]

Merged in m-c:
http://hg.mozilla.org/mozilla-central/rev/2d24929f1d65