660433 - Remove nsIDOMNSHTMLFormElement, nsIDOMNSHTMLTextAreaElement

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: textarea

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: form

Comment 2

[Mounir Lamouri (:mounir)]

Comment on attachment 535836 [details] [diff] [review]
form

Review of attachment 535836 [details] [diff] [review]:
-----------------------------------------------------------------

FWIW, f=me

::: dom/interfaces/html/nsIDOMHTMLFormElement.idl
@@ +69,5 @@
>    void                      submit();
>    void                      reset();
> +
> +           attribute DOMString            encoding;
> +  boolean        checkValidity();

Could you put these lines in the same order than the IDL in the WHATWG specs:
http://www.whatwg.org/specs/web-apps/current-work/multipage/forms.html#the-form-element

IOW, move encoding after enctype and checkValidity after reset() (with indentation fixes).

Comment 3

[Mounir Lamouri (:mounir)]

Comment on attachment 535835 [details] [diff] [review]
textarea

Review of attachment 535835 [details] [diff] [review]:
-----------------------------------------------------------------

FWIW, f=me

::: dom/interfaces/html/nsIDOMHTMLTextAreaElement.idl
@@ +93,5 @@
> +  boolean checkValidity();
> +  void setCustomValidity(in DOMString error);
> +
> +  void                       setSelectionRange(in long selectionStart,
> +                                               in long selectionEnd);

Could you put these new lines in the same order as the WHATWG specs:
http://www.whatwg.org/specs/web-apps/current-work/multipage/the-button-element.html#the-textarea-element

Comment 4

[Peter Van der Beken [:peterv]]

Comment on attachment 535836 [details] [diff] [review]
form

Review of attachment 535836 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/interfaces/html/nsIDOMHTMLFormElement.idl
@@ +69,5 @@
>    void                      submit();
>    void                      reset();
> +
> +           attribute DOMString            encoding;
> +  boolean        checkValidity();

Whitespace for checkValidity seems inconsistent with rest of the file.

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 535836 [details] [diff] [review]
form

http://hg.mozilla.org/mozilla-central/rev/0acc408d9a67

Comment 6

[Peter Van der Beken [:peterv]]

Comment on attachment 535835 [details] [diff] [review]
textarea

Review of attachment 535835 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/interfaces/html/nsIDOMHTMLTextAreaElement.idl
@@ +84,5 @@
> +   * "off". "soft" is the default.
> +   */
> +  [Null(Stringify)] attribute DOMString wrap;
> +
> +  // The following lines are parte of the constraint validation API, see:

s/parte/part/

Comment 7

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 535835 [details] [diff] [review]
textarea

http://hg.mozilla.org/mozilla-central/rev/d2bdaef8a701