Closed
Bug 660433
Opened 13 years ago
Closed 13 years ago
Remove nsIDOMNSHTMLFormElement, nsIDOMNSHTMLTextAreaElement
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla7
People
(Reporter: Ms2ger, Assigned: Ms2ger)
Details
(Keywords: dev-doc-complete)
Attachments
(2 files)
No description provided.
Attachment #535835 -
Flags: review?(peterv)
Flags: in-testsuite-
Assignee | ||
Updated•13 years ago
|
OS: Android → All
Assignee | ||
Comment 1•13 years ago
|
||
Attachment #535836 -
Flags: review?(peterv)
Comment 2•13 years ago
|
||
Comment on attachment 535836 [details] [diff] [review] form Review of attachment 535836 [details] [diff] [review]: ----------------------------------------------------------------- FWIW, f=me ::: dom/interfaces/html/nsIDOMHTMLFormElement.idl @@ +69,5 @@ > void submit(); > void reset(); > + > + attribute DOMString encoding; > + boolean checkValidity(); Could you put these lines in the same order than the IDL in the WHATWG specs: http://www.whatwg.org/specs/web-apps/current-work/multipage/forms.html#the-form-element IOW, move encoding after enctype and checkValidity after reset() (with indentation fixes).
Attachment #535836 -
Flags: feedback+
Comment 3•13 years ago
|
||
Comment on attachment 535835 [details] [diff] [review] textarea Review of attachment 535835 [details] [diff] [review]: ----------------------------------------------------------------- FWIW, f=me ::: dom/interfaces/html/nsIDOMHTMLTextAreaElement.idl @@ +93,5 @@ > + boolean checkValidity(); > + void setCustomValidity(in DOMString error); > + > + void setSelectionRange(in long selectionStart, > + in long selectionEnd); Could you put these new lines in the same order as the WHATWG specs: http://www.whatwg.org/specs/web-apps/current-work/multipage/the-button-element.html#the-textarea-element
Attachment #535835 -
Flags: feedback+
Comment 4•13 years ago
|
||
Comment on attachment 535836 [details] [diff] [review] form Review of attachment 535836 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/interfaces/html/nsIDOMHTMLFormElement.idl @@ +69,5 @@ > void submit(); > void reset(); > + > + attribute DOMString encoding; > + boolean checkValidity(); Whitespace for checkValidity seems inconsistent with rest of the file.
Attachment #535836 -
Flags: review?(peterv) → review+
Assignee | ||
Comment 5•13 years ago
|
||
Comment on attachment 535836 [details] [diff] [review] form http://hg.mozilla.org/mozilla-central/rev/0acc408d9a67
Attachment #535836 -
Flags: checked-in+
Assignee | ||
Updated•13 years ago
|
Keywords: dev-doc-needed
Updated•13 years ago
|
Attachment #535836 -
Flags: checked-in+ → checkin+
Comment 6•13 years ago
|
||
Comment on attachment 535835 [details] [diff] [review] textarea Review of attachment 535835 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/interfaces/html/nsIDOMHTMLTextAreaElement.idl @@ +84,5 @@ > + * "off". "soft" is the default. > + */ > + [Null(Stringify)] attribute DOMString wrap; > + > + // The following lines are parte of the constraint validation API, see: s/parte/part/
Attachment #535835 -
Flags: review?(peterv) → review+
Assignee | ||
Comment 7•13 years ago
|
||
Comment on attachment 535835 [details] [diff] [review] textarea http://hg.mozilla.org/mozilla-central/rev/d2bdaef8a701
Attachment #535835 -
Flags: checkin+
Assignee | ||
Updated•13 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla7
Updated•13 years ago
|
Keywords: dev-doc-needed → dev-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•